From 08b982df75d6496c30a747e88ebb3cd961206ce7 Mon Sep 17 00:00:00 2001 From: drepper Date: Thu, 27 Feb 2003 23:44:20 +0000 Subject: [PATCH] Release lock before waking up the waiters. --- .../sysv/linux/i386/i486/pthread_cond_broadcast.S | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/nptl/sysdeps/unix/sysv/linux/i386/i486/pthread_cond_broadcast.S b/nptl/sysdeps/unix/sysv/linux/i386/i486/pthread_cond_broadcast.S index fffef03bd5..34bf95af15 100644 --- a/nptl/sysdeps/unix/sysv/linux/i386/i486/pthread_cond_broadcast.S +++ b/nptl/sysdeps/unix/sysv/linux/i386/i486/pthread_cond_broadcast.S @@ -70,13 +70,24 @@ __pthread_cond_broadcast: 3: movl %ecx, (%ebx) movl %eax, 4(%ebx) + /* Unlock. */ + LOCK + decl cond_lock-wakeup_seq(%ebx) + jne 7f + /* Wake up all threads. */ - movl $FUTEX_WAKE, %ecx +8: movl $FUTEX_WAKE, %ecx xorl %esi, %esi movl $SYS_futex, %eax movl $0x7fffffff, %edx ENTER_KERNEL + xorl %eax, %eax + popl %ebx + popl %esi + ret + + .align 16 /* Unlock. */ 4: LOCK decl cond_lock-wakeup_seq(%ebx) @@ -98,10 +109,14 @@ __pthread_cond_broadcast: jmp 2b /* Unlock in loop requires waekup. */ -5: - leal cond_lock-wakeup_seq(%ebx), %eax +5: leal cond_lock-wakeup_seq(%ebx), %eax call __lll_mutex_unlock_wake jmp 6b + + /* Unlock in loop requires waekup. */ +7: leal cond_lock-wakeup_seq(%ebx), %eax + call __lll_mutex_unlock_wake + jmp 8b .size __pthread_cond_broadcast, .-__pthread_cond_broadcast versioned_symbol (libpthread, __pthread_cond_broadcast, pthread_cond_broadcast, GLIBC_2_3_2) -- 2.11.0