Mark Chiu e26chiu
  • Joined on 2022-01-11
e26chiu approved www/cs-2022-class-profile#180 2023-02-19 14:34:22 -05:00
Adjusted demographics text

LGTM!

e26chiu approved www/cs-2022-class-profile#178 2023-02-15 17:26:22 -05:00
Final edits

LGTM! 🚀🚀🚀🚀🚀🚀🚀

e26chiu pushed to shahanneda/final-changes at www/cs-2022-class-profile 2023-02-15 16:23:21 -05:00
71b18eb487 Add links to prof names, fix text
e26chiu approved www/cs-2022-class-profile#176 2023-02-13 18:57:43 -05:00
Added min width to missing graphs

Tested this and works locally. LGTM!

e26chiu approved www/cs-2022-class-profile#177 2023-02-13 18:48:34 -05:00
Added favicon

LGTM!

e26chiu created pull request www/cs-2022-class-profile#174 2023-02-12 14:59:29 -05:00
Fix boxplot labels and incorrect questions order (Closes #147)
e7d6d682f3 Fix Boxplot labels, spacing + remove hardcoded values
9170034b21 Fix incorrect question order
Compare 2 commits »
e26chiu commented on pull request www/cs-2022-class-profile#173 2023-02-12 13:26:58 -05:00
Recopied text for intamacy and drugs and post grad page

Why is there a space here?

e26chiu approved www/cs-2022-class-profile#173 2023-02-12 13:26:58 -05:00
Recopied text for intamacy and drugs and post grad page

LGTM! I just have a small comment about something to change. Non-blocking though.

e26chiu approved www/cs-2022-class-profile#172 2023-02-12 13:19:46 -05:00
Recopy Coop Page

Everything LGTM! Interesting that you also committed the script you used to convert the data to text and value. I might consider also putting my scripts there for future usage!🤔

e26chiu commented on pull request www/cs-2022-class-profile#158 2023-02-04 14:17:21 -05:00
WIP: Creating component switcher

Just a question, where did you choose these colours from? I think we should aim to reuse colours defined in the _app.css file as much as possible instead of definining new colours. It's also better if you define the variable names in that file so that it will be easier to change these values later on (since they are all mostly in that file).

e26chiu commented on pull request www/cs-2022-class-profile#158 2023-02-04 14:17:21 -05:00
WIP: Creating component switcher

There should be perhaps a cursor: pointer property to make the button seem clickable?

e26chiu commented on pull request www/cs-2022-class-profile#158 2023-02-04 14:17:21 -05:00
WIP: Creating component switcher

Instead of hardcoding this value, we could perhaps use buttonList[0]?

e26chiu suggested changes for www/cs-2022-class-profile#158 2023-02-04 14:17:21 -05:00
WIP: Creating component switcher

Hey @r2shuai ! Thanks for working on this issue, it's definitely more complex since we don't have the design for this component! In our case (or at least, in this term), the type of the graph shouldn't change (it should be the same for all terms! Have we considered trying to put the buttons above instead? How would that look?

e26chiu commented on pull request www/cs-2022-class-profile#159 2023-02-04 13:22:19 -05:00
Fixed word cloud data issues

Some of these categories are repeat of each other. E.g. Communication, Become more social, (to a lesser extent) Improved relationship

e26chiu commented on pull request www/cs-2022-class-profile#159 2023-02-04 13:22:19 -05:00
Fixed word cloud data issues

Is "Have sex" comment SFW?

e26chiu commented on pull request www/cs-2022-class-profile#159 2023-02-04 13:22:19 -05:00
Fixed word cloud data issues

Mindfulness & Mature sounds weird, I don't know if it's just me... I prefer keeping mindfulness only.

e26chiu approved www/cs-2022-class-profile#159 2023-02-04 13:22:19 -05:00
Fixed word cloud data issues

LGTM! I have a few non-blocking questions about miscellaneous data.

e26chiu pushed to shahanneda/fix-word-cloud-issues at www/cs-2022-class-profile 2023-02-04 13:20:52 -05:00
301a1f76f0 Fix grammar mistake