Mark Chiu e26chiu
  • Joined on Jan 11, 2022
Loading Heatmap…

e26chiu commented on pull request www/www-new#546

add leo shen as sysadmin

😭😭

4 days ago

e26chiu approved www/www-new#546

add leo shen as sysadmin

LGTM @y266shen ! Very original!

4 days ago

e26chiu approved www/www-new#547

Added election news

LGTM @dlslo ! Thanks for working on this!

4 days ago

e26chiu approved www/cs-2022-class-profile#155

Change-Legend-Labels_And_Colors

LGTM @tcsrikan ! Ready to merge! 👍

4 days ago

e26chiu commented on pull request www/cs-2022-class-profile#157

Fix weird percentage number and add percent symbol

I'm not sure I understand why we are hiding the data value for this specific graph tooltip?

4 days ago

e26chiu approved www/cs-2022-class-profile#157

Fix weird percentage number and add percent symbol

@snedadah I have only one question regarding hiding data value. I also added labels to other tooltips and adjusted the data for one of the stacked bar graph (from 0.01 to 1) to match the other percentages of data. Nothing blocking this from being merged though. Good job!

4 days ago

e26chiu pushed to shahanneda/fix-percent at www/cs-2022-class-profile

  • e4a1154032 Fix tooltip formatting + calibrate data

4 days ago

e26chiu approved www/www-new#544

Added myself (annie sun) to website

LGTM @a34sun !

5 days ago

e26chiu commented on pull request www/cs-2022-class-profile#153

Fixed incorrect data

I also noticed in the original data, there is a generic Computer Software category which most people opted (65). I didn't include this category in my change because it wasn't telling us anything new. Do we want to still include this category?

6 days ago

e26chiu approved www/cs-2022-class-profile#153

Fixed incorrect data

Looks like every point in the document was addressed, good job @snedadah ! I changed some of the data points according to the google sheets (inconsistencies, etc.) Everything should be ready to merge

6 days ago

e26chiu pushed to fix-data at www/cs-2022-class-profile

6 days ago

e26chiu approved www/www-new#543

Added Darren Lo to the Team page

LGTM! @dlslo Feel free to add a headshot to the `images/team/` folder (if you want to)!

7 days ago

e26chiu commented on pull request www/cs-2022-class-profile#152

View button font change

Small suggestion (optional): if you've looked at other parts of the code that specify the font family, we have `monospace` as the fallback font family. You can add that! Not a blocker for this PR though!

1 week ago

e26chiu approved www/cs-2022-class-profile#151

Merge religion

LGTM! Nice work again @r2shuai ! You're really quick! :D

1 week ago

e26chiu approved www/cs-2022-class-profile#150

Fixing the link issue on contributors page. Now the redirection occurs only when link exists.

LGTM! @r2shuai I tested this locally and it works well! You can merge this! Thank you for working on a class profile issue this early!

1 week ago

e26chiu approved www/www-new#537

Fixed exec name showing middle name

LGTM! @snedadah Nice work on integrating interfaces!

1 week ago