My oriignal thought before was we'd just lint the files that's being modified but rethinking about it, there shouldn't it be a problem with just relinting everything which is easier
The latest commit runs flake8 through docker but since it's just code linting, it just starts a python docker image and uses flake8 installed in the venv location created when setting up the…
At the end of the STAGED_FILES variable declaration it has grep ".py\{0,1\}$"
so it should only grab python files
It's in dev-requirements.txt. On my machine, I run
flake8
from inside one of the Docker containers, in the activated venv, but I rungit commit
outside of the container, directly on the…
Might want to consider the case where file name can be white space. Just adding a
IFS='\n'
before the for loop is probably enough.
Good point. That'll be addressed
We are just linting all the files that are being committed. Technically, all files should be free of linting issues but I've just decided to only apply linting on the files that need to be changed.
Do you mind clarifying this flake8 script you're referring to? @merenber