Justin Chung j24chung
  • Joined on 2022-09-14
j24chung pushed to feature-80 at public/pyceo 2023-05-28 17:54:42 -04:00
a6ad08d2c0 Update README
7cec1425b3 Simplify linting git hook script
Compare 2 commits »
j24chung commented on pull request public/pyceo#86 2023-05-28 17:14:56 -04:00
Add linting pre-commit hook and hook install script

My oriignal thought before was we'd just lint the files that's being modified but rethinking about it, there shouldn't it be a problem with just relinting everything which is easier

j24chung created pull request cloud/docs#1 2023-05-28 14:12:52 -04:00
Add documentation for setting up Minecraft server(s)
j24chung created branch minecraft in cloud/docs 2023-05-28 14:06:05 -04:00
j24chung pushed to minecraft at cloud/docs 2023-05-28 14:06:05 -04:00
7d0ee8171c Add Minecraft page to nav
ef37a4b21c Add minecraft documentation
Compare 2 commits »
j24chung commented on pull request public/pyceo#86 2023-05-27 16:44:46 -04:00
Add linting pre-commit hook and hook install script

The latest commit runs flake8 through docker but since it's just code linting, it just starts a python docker image and uses flake8 installed in the venv location created when setting up the…

j24chung pushed to feature-80 at public/pyceo 2023-05-27 16:42:32 -04:00
42a74c2bc9 Implement feedback in pre-commit script
j24chung commented on pull request public/pyceo#86 2023-05-27 15:41:45 -04:00
Add linting pre-commit hook and hook install script

Fair. Will address it rn.

j24chung commented on pull request public/pyceo#86 2023-05-27 15:41:10 -04:00
Add linting pre-commit hook and hook install script

At the end of the STAGED_FILES variable declaration it has grep ".py\{0,1\}$" so it should only grab python files

j24chung commented on pull request public/pyceo#86 2023-05-27 15:19:50 -04:00
Add linting pre-commit hook and hook install script

It's in dev-requirements.txt. On my machine, I run flake8 from inside one of the Docker containers, in the activated venv, but I run git commit outside of the container, directly on the…

j24chung commented on pull request public/pyceo#86 2023-05-27 15:11:59 -04:00
Add linting pre-commit hook and hook install script

Might want to consider the case where file name can be white space. Just adding a IFS='\n' before the for loop is probably enough.

Good point. That'll be addressed

j24chung pushed to feature-80 at public/pyceo 2023-02-04 21:44:56 -05:00
8109758914 Fix typo in linting check
j24chung commented on pull request public/pyceo#86 2023-02-04 00:10:20 -05:00
Add linting pre-commit hook and hook install script

Haha oops. Need to fix my typo

j24chung commented on pull request public/pyceo#86 2023-02-04 00:10:00 -05:00
Add linting pre-commit hook and hook install script

We are just linting all the files that are being committed. Technically, all files should be free of linting issues but I've just decided to only apply linting on the files that need to be changed.

j24chung commented on pull request public/pyceo#86 2023-02-04 00:08:57 -05:00
Add linting pre-commit hook and hook install script

Do you mind clarifying this flake8 script you're referring to? @merenber

j24chung created pull request public/pyceo#86 2022-11-19 18:37:28 -05:00
Add linting pre-commit hook and hook install script
j24chung pushed to feature-80 at public/pyceo 2022-11-19 18:36:09 -05:00
da51c4309c Add linting pre-commit hook and hook install script
j24chung created branch feature-80 in public/pyceo 2022-11-19 18:21:17 -05:00
j24chung pushed to feature-80 at public/pyceo 2022-11-19 18:21:17 -05:00