Leon Zhang l227zhan
  • Joined on 2023-09-11
l227zhan commented on issue public/pyceo#108 2024-02-11 21:07:11 -05:00
Take over www/membership-confirmation

Is this still an open issue? It appears that the link is either dead, or private.

l227zhan pushed to master at public/pyceo 2024-02-11 16:33:43 -05:00
l227zhan 2024-02-11 16:33:42 -05:00
l227zhan pushed to 124-fix-regression at public/pyceo 2024-02-11 16:18:42 -05:00
9ec816aabf Merge branch 'master' into 124-fix-regression
c83bbe2563 update packaging version and instructions (#122)
Compare 2 commits »
l227zhan closed issue public/pyceo#124 2024-02-11 16:15:52 -05:00
TUI position views are broken
l227zhan pushed to 124-fix-regression at public/pyceo 2024-02-10 16:14:22 -05:00
bb3e38cb44 Merge branch 'master' into 124-fix-regression
32709ad401 Revert "Fix for regression in issue #124 (#125)"
3780662ba4 Fix for regression in issue #124 (#125)
Compare 3 commits »
l227zhan created pull request public/pyceo#127 2024-02-10 15:59:50 -05:00
See #125
l227zhan commented on pull request public/pyceo#125 2024-02-10 15:57:42 -05:00
Fix for regression in issue #124

I added it to the dict, but this may change the output of some unit tests once again

l227zhan pushed to 124-fix-regression at public/pyceo 2024-02-10 15:57:15 -05:00
bebdf89577 Fixed missing events-lead position name in dictionary
cc0eb7fb91 Revert "See Issue #124, defaulted to empty string instead of None"
eae97da08d Revert "Added fallback for position name lookup in SetPositionsView"
Compare 3 commits »
l227zhan pushed to 124-fix-regression at public/pyceo 2024-02-10 15:50:04 -05:00
e337a2ae4e Added fallback for position name lookup in SetPositionsView
36c8d076fe See Issue #124, defaulted to empty string instead of None
Compare 2 commits »
l227zhan created branch 124-fix-regression in public/pyceo 2024-02-10 15:50:04 -05:00
l227zhan created branch 124-fix-regression in public/pyceo 2024-02-10 15:50:03 -05:00
l227zhan commented on pull request public/pyceo#125 2024-02-10 15:43:59 -05:00
Fix for regression in issue #124

Ugh, this got merged before I got a chance to comment. What I said in #124 was wrong. We don't want to show an empty string. The real problem is that the dict in ceo/tui/views/position_names.py…

l227zhan commented on issue public/pyceo#124 2024-02-10 15:33:46 -05:00
TUI position views are broken

Thank you for letting me know, I have pushed 3780662ba4 to resolve this issue.

l227zhan closed issue public/pyceo#124 2024-02-10 15:33:46 -05:00
TUI position views are broken
l227zhan deleted branch 124-fix-regression from public/pyceo 2024-02-10 15:32:56 -05:00
l227zhan pushed to master at public/pyceo 2024-02-10 15:32:55 -05:00
3780662ba4 Fix for regression in issue #124 (#125)
l227zhan merged pull request public/pyceo#125 2024-02-10 15:32:54 -05:00
Fix for regression in issue #124
l227zhan pushed to 124-fix-regression at public/pyceo 2024-02-10 15:14:53 -05:00
e337a2ae4e Added fallback for position name lookup in SetPositionsView
l227zhan created pull request public/pyceo#125 2024-02-10 15:13:03 -05:00
Fix for regression in issue #124