Add links from DB to JSON function #12
Merged
w25tran
merged 0 commits from william/regen-JSON
into main
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'william/regen-JSON'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Not sure if I did this correctly.
Looks good to me so far!
What's the format of the JSON? We want something like:
[{'name': '...', 'url': ...}, ...]
. I'm just a little confused because of thedict
andzip
call, but if it matches that, should be good to merge.We should add some tests, but we can do that as part of a separate MR/later.
Here's the output if I print the resulting JSON:
I just used the
dict
andzip
call as a generalized way to match column names to column values.Looks good to me!
approved this merge request
added 4 commits
main
Compare with previous version
Reviewers