update click count method #14

Merged
c29wan merged 0 commits from cathtask1 into main 2 years ago
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added POST method to update click count in database per click

added POST method to update click count in database per click
n3parikh (Migrated from git.uwaterloo.ca) approved these changes 2 years ago
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

Ideally we shouldn't be printing urls using the print function. We should use the logging module instead. Here's a guide! https://docs.python.org/3/howto/logging.html

Ideally we shouldn't be printing urls using the `print` function. We should use the `logging` module instead. Here's a guide! https://docs.python.org/3/howto/logging.html
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

Take a look at the diagram in the readme for the correct route :)
https://git.uwaterloo.ca/csc/linktree#architecture

I have also specified the payload type that the backend will recieve in that document.

In this case, the payload looks something like this: {"url": "http://example.com", "name": "An example link"}

Take a look at the diagram in the readme for the correct route :) https://git.uwaterloo.ca/csc/linktree#architecture I have also specified the payload type that the backend will recieve in that document. In this case, the payload looks something like this: `{"url": "http://example.com", "name": "An example link"}`
n3parikh commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

You can remove this import, there's already one below of the same package (on line 5).

You can remove this import, there's already one below of the same package (on line 5).
n3parikh commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

You can remove this comment, and then add a one line comment just above the function describing it (doesn't have to be too detailed).

You can remove this comment, and then add a one line comment just above the function describing it (doesn't have to be too detailed).
n3parikh commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

Left a few more comments, but looks good overall!

Left a few more comments, but looks good overall!
n3parikh commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

requested review from @n3parikh

requested review from @n3parikh
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/linktree/-/merge_requests/9/diffs?diff_id=51663&start_sha=04f85228c6d304a6aa5a9911f2814c6f977ad1f7#cb368897cc5bf4934e15bc7a3c0b7d3b69446875_33_32)
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/linktree/-/merge_requests/9/diffs?diff_id=51663&start_sha=04f85228c6d304a6aa5a9911f2814c6f977ad1f7#cb368897cc5bf4934e15bc7a3c0b7d3b69446875_30_30)
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/linktree/-/merge_requests/9/diffs?diff_id=51663&start_sha=04f85228c6d304a6aa5a9911f2814c6f977ad1f7#cb368897cc5bf4934e15bc7a3c0b7d3b69446875_44_45)
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 1 commit

  • b614fdb9 - added custom error, corrected routing

Compare with previous version

added 1 commit <ul><li>b614fdb9 - added custom error, corrected routing</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/9/diffs?diff_id=51663&start_sha=04f85228c6d304a6aa5a9911f2814c6f977ad1f7)
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/linktree/-/merge_requests/9/diffs?diff_id=52026&start_sha=b614fdb93692b5cb2111d3bb8bde438aa7651366#cb368897cc5bf4934e15bc7a3c0b7d3b69446875_2_2)
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 1 commit

  • cea734ef - first draft for get_links()

Compare with previous version

added 1 commit <ul><li>cea734ef - first draft for get_links()</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/9/diffs?diff_id=52026&start_sha=b614fdb93692b5cb2111d3bb8bde438aa7651366)
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 2 commits

  • 2a51afdc - Revert "first draft for get_links()"
  • 48323402 - removed duplicate import sqlite

Compare with previous version

added 2 commits <ul><li>2a51afdc - Revert &quot;first draft for get_links()&quot;</li><li>48323402 - removed duplicate import sqlite</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/9/diffs?diff_id=52083&start_sha=cea734efd78bb2a3b83dfdb31a328bae8df0298f)
c29wan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 5 commits

  • 48323402...fe4e61dd - 3 commits from branch main
  • b3cceba4 - removed jsonify
  • 40e19977 - Merge branch 'main' into cathtask1

Compare with previous version

added 5 commits <ul><li>48323402...fe4e61dd - 3 commits from branch <code>main</code></li><li>b3cceba4 - removed jsonify</li><li>40e19977 - Merge branch &#39;main&#39; into cathtask1</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/9/diffs?diff_id=52084&start_sha=48323402e5166cefb0880fe7df28134394e196b2)
n3parikh commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

approved this merge request

approved this merge request

Reviewers

The pull request has been merged.
Sign in to join this conversation.
No reviewers
No Label deployment
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: old/LinkList#14
Loading…
There is no content yet.