old
/
LinkList
2
0
Fork 0
Code Issues 3 Pull Requests Projects Releases Wiki Activity
Labels Milestones

Login page for links editor #19

Merged
a258wang merged 0 commits from feat/authentication into main 2 years ago
Conversation 21 Commits N/A Files Changed N/A
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

The login screen for the LinkTree (LinkList?) editor.

Summary:

  • The login screen is rendered from ./pages/editor.tsx in the frontend directory
  • Relevant components/context are found in the ./components/Login directory in the frontend directory
  • The components are more or less styled and functional... see notes and TODO below for nitpicky details

Notes: (ie. things that are currently happening that probably need to be changed)

  • Currently, a blank "Editor" component is rendered upon successful login (the component is found at ./components/editor.tsx in the frontend directory)
  • In order to use the LinkTree font (Karla), I directly modified the sans font family in tailwind.config.js - so all the login components are currently styled using font-sans instead of font-<customFontFamily> or something
  • Currently, the login/password is hardcoded - still need to figure out how to hook it up to backend 😅

TODO:

  • Responsive styling
  • Use backend's auth endpoint instead of hardcoding the password
  • Update the CSC logo in the login header?
The login screen for the LinkTree (LinkList?) editor. **Summary:** - The login screen is rendered from `./pages/editor.tsx` in the frontend directory - Relevant components/context are found in the `./components/Login` directory in the frontend directory - The components are more or less styled and functional... see notes and TODO below for nitpicky details **Notes:** (ie. things that are currently happening that probably need to be changed) - Currently, a blank "Editor" component is rendered upon successful login (the component is found at `./components/editor.tsx` in the frontend directory) - In order to use the LinkTree font (Karla), I directly modified the sans font family in `tailwind.config.js` - so all the login components are currently styled using `font-sans` instead of `font-<customFontFamily>` or something - Currently, the login/password is hardcoded - still need to figure out how to hook it up to backend :sweat_smile: **TODO:** - Responsive styling - Use backend's auth endpoint instead of hardcoding the password - Update the CSC logo in the login header?
a3thakra (Migrated from git.uwaterloo.ca) approved these changes 2 years ago
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed the description

changed the description
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner 
import Editor from "components/editor";

Relative imports are fine, but you don't need to use them here. :)

We can also skip the .tsx at the end

```suggestion:-0+0 import Editor from "components/editor"; ``` Relative imports are fine, but you don't need to use them here. :) We can also skip the `.tsx` at the end
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed title from {-feat/authentication-} to {+Login page for links editor+}

changed title from **{-feat/authentication-}** to **{+Login page for links editor+}**
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/linktree/-/merge_requests/14/diffs?diff_id=51729&start_sha=9791bf5791be2b1e73d1c984268241e953aa46f3#1300041c72ef072f4d429adf9886818d0ce15e24_6_3)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 1 commit

  • f52802ce - Fix TypeScript types and code format, change name to linklist

Compare with previous version

added 1 commit <ul><li>f52802ce - Fix TypeScript types and code format, change name to linklist</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/14/diffs?diff_id=51729&start_sha=9791bf5791be2b1e73d1c984268241e953aa46f3)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed the description

changed the description
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

resolved all threads

resolved all threads
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 1 commit

  • b04384b7 - Fix more TypeScript types

Compare with previous version

added 1 commit <ul><li>b04384b7 - Fix more TypeScript types</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/14/diffs?diff_id=51730&start_sha=f52802cec18fdca6f4b55cf755a6c1b6fc4fa436)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

requested review from @a3thakra

requested review from @a3thakra
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner 
            onChange={(event) => setPassword(event.target.value)}
```suggestion:-0+0 onChange={(event) => setPassword(event.target.value)} ```
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

Move the logic from LoginBox up here: {loginFailed ? (<div className="text-red-600">Invalid credentials.</div>) : null}

Move the logic from LoginBox up here: `{loginFailed ? (<div className="text-red-600">Invalid credentials.</div>) : null}`
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/csc/linktree/-/merge_requests/14/diffs?diff_id=52200&start_sha=b04384b7feb57a1d25592f4eff86048e44accaac#b8d48dfb4dbb86bccfe0ac4dd16cd9154bdf8b28_53_35)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/csc/linktree/-/merge_requests/14/diffs?diff_id=52200&start_sha=b04384b7feb57a1d25592f4eff86048e44accaac#b8d48dfb4dbb86bccfe0ac4dd16cd9154bdf8b28_35_22)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 1 commit

  • dfa94bb2 - Clean code

Compare with previous version

added 1 commit <ul><li>dfa94bb2 - Clean code</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/14/diffs?diff_id=52200&start_sha=b04384b7feb57a1d25592f4eff86048e44accaac)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

resolved all threads

resolved all threads
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner 
      : ""

Use empty string instead

```suggestion:-0+0 : "" ``` Use empty string instead
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/linktree/-/merge_requests/14/diffs?diff_id=52306&start_sha=dfa94bb2cc0a6a5b362e33efc133c47a392bee2b#b8d48dfb4dbb86bccfe0ac4dd16cd9154bdf8b28_12_12)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 1 commit

  • 0e82d21e - Improve layout for short screens

Compare with previous version

added 1 commit <ul><li>0e82d21e - Improve layout for short screens</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/14/diffs?diff_id=52306&start_sha=dfa94bb2cc0a6a5b362e33efc133c47a392bee2b)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

resolved all threads

resolved all threads
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 13 commits

  • 0e82d21e...7389e555 - 12 commits from branch main
  • db5d49d7 - Merge remote-tracking branch 'origin/main' into feat/authentication

Compare with previous version

added 13 commits <ul><li>0e82d21e...7389e555 - 12 commits from branch <code>main</code></li><li>db5d49d7 - Merge remote-tracking branch &#39;origin/main&#39; into feat/authentication</li></ul> [Compare with previous version](/csc/linktree/-/merge_requests/14/diffs?diff_id=52313&start_sha=0e82d21e0247a8a9012e18526b14a68237e122e7)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

approved this merge request

approved this merge request

Reviewers

a3thakra
The pull request has been merged.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a3thakra
Labels
Apply labels
Clear labels
deployment
No Label deployment
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: old/LinkList#19
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/authentication'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes