Hookup editor login #23

Merged
a3thakra merged 1 commits from hookup-editor-login into hookup-public-page 2 years ago
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

cc: @a258wang this is how Steven and I wired up the app to do authentication. Let me know if you have any questions!

cc: @a258wang this is how Steven and I wired up the app to do authentication. Let me know if you have any questions!
q63xu (Migrated from git.uwaterloo.ca) approved these changes 2 years ago
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

@n3parikh I had to change the scheme from Basic to CustomBasic to prevent popups on 401s.

More info: https://github.com/miguelgrinberg/Flask-HTTPAuth/issues/22

@n3parikh I had to change the `scheme` from `Basic` to `CustomBasic` to prevent popups on 401s. More info: https://github.com/miguelgrinberg/Flask-HTTPAuth/issues/22
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

loginFailed is a UI concern, not an auth concern.

`loginFailed` is a UI concern, not an auth concern.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

We shouldn't setState for components which have been unmounted.

We shouldn't `setState` for components which have been unmounted.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

This matches /api/editor/links/foo/bar/whatever

This matches `/api/editor/links/foo/bar/whatever`
q63xu commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

approved this merge request

approved this merge request

Reviewers

The pull request has been merged.
Sign in to join this conversation.
No reviewers
No Label deployment
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: old/LinkList#23
Loading…
There is no content yet.