add interviewer database and self-signup functionality #7

Open
xc22zhan wants to merge 2 commits from interview into master
xc22zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner
There is no content yet.
k4tu commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

Is there a way we can give a more descriptive error? It would be nice to know what args the command is looking for.

Is there a way we can give a more descriptive error? It would be nice to know what args the command is looking for.
xc22zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/discord-bot/-/merge_requests/7/diffs?diff_id=56697&start_sha=5affdb97adb9930b17c27cbb3798508e1bc7df52#7e7ef8f416e9404a88d5be3113f74bfabe81e0cc_15_15)
xc22zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

added 1 commit

Compare with previous version

added 1 commit <ul><li>92e5b288 - add detailed error message</li></ul> [Compare with previous version](/csc/discord-bot/-/merge_requests/7/diffs?diff_id=56697&start_sha=5affdb97adb9930b17c27cbb3798508e1bc7df52)
w388zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

I think we can move this method to like a initDB function in the db module, where we create any tables we need if necessary

I think we can move this method to like a `initDB` function in the db module, where we create any tables we need if necessary
w388zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

we can talk about what command we should use in the next meeting

we can talk about what command we should use in the next meeting
w388zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

should do something like

const db = await openDB()
db.get(...)
should do something like ``` const db = await openDB() db.get(...) ```
w388zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

I think these messages should be more friendly, since our bot is Codey, so we should think about how Codey would respond. We can also talk about this more in our next meeting.

I think these messages should be more friendly, since our bot is Codey, so we should think about how Codey would respond. We can also talk about this more in our next meeting.
w388zhan commented 2 years ago (Migrated from git.uwaterloo.ca)
Owner

same here, should avoid using .then if we are using async/await

same here, should avoid using `.then` if we are using async/await
This pull request has changes conflicting with the target branch.
index.ts
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: old/discord-bot#7
Loading…
There is no content yet.