old
/
discord-bot
2
0
Fork 0
Code Issues Pull Requests 2 Projects Releases Wiki Activity

add interviewer database and self-signup functionality #7

Open
xc22zhan wants to merge 2 commits from interview into master
pull from: interview
merge into: old:master
Conversation 8 Commits 2 Files Changed 3 +46 -13
xc22zhan commented 2021-05-26 21:27:53 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link
No description provided.
k4tu commented 2021-05-26 21:30:57 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

Is there a way we can give a more descriptive error? It would be nice to know what args the command is looking for.

Is there a way we can give a more descriptive error? It would be nice to know what args the command is looking for.
xc22zhan commented 2021-05-26 21:46:04 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/discord-bot/-/merge_requests/7/diffs?diff_id=56697&start_sha=5affdb97adb9930b17c27cbb3798508e1bc7df52#7e7ef8f416e9404a88d5be3113f74bfabe81e0cc_15_15)
xc22zhan commented 2021-05-26 21:46:05 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>92e5b288 - add detailed error message</li></ul> [Compare with previous version](/csc/discord-bot/-/merge_requests/7/diffs?diff_id=56697&start_sha=5affdb97adb9930b17c27cbb3798508e1bc7df52)
w388zhan commented 2021-05-26 22:13:52 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

I think we can move this method to like a initDB function in the db module, where we create any tables we need if necessary

I think we can move this method to like a `initDB` function in the db module, where we create any tables we need if necessary
w388zhan commented 2021-05-26 22:14:05 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

we can talk about what command we should use in the next meeting

we can talk about what command we should use in the next meeting
w388zhan commented 2021-05-26 22:15:06 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

should do something like

const db = await openDB()
db.get(...)
should do something like ``` const db = await openDB() db.get(...) ```
w388zhan commented 2021-05-26 22:16:07 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

I think these messages should be more friendly, since our bot is Codey, so we should think about how Codey would respond. We can also talk about this more in our next meeting.

I think these messages should be more friendly, since our bot is Codey, so we should think about how Codey would respond. We can also talk about this more in our next meeting.
w388zhan commented 2021-05-26 22:24:14 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

same here, should avoid using .then if we are using async/await

same here, should avoid using `.then` if we are using async/await
This pull request has changes conflicting with the target branch.
  • index.ts
repo.pulls.merge_instruction_hint

step1

repo.pulls.merge_instruction_step1_desc
git checkout -b interview master
git pull origin interview

step2

repo.pulls.merge_instruction_step2_desc
git checkout master
git merge --no-ff interview
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: old/discord-bot#7
No description provided.
Delete Branch "interview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?