public
/
pyceo
27
1
Fork 3
Code Issues 25 Pull Requests 5 Projects Releases 1 Wiki Activity

add username validation to ceod members create_user api route
continuous-integration/drone/pr Build is failing Details

This commit is contained in:
Ohm Patel 2024-01-17 03:17:36 +00:00
parent dc1b3209d2
commit 3f751ccece
Signed by: o32patel
GPG Key ID: 096A9E27B27F535C
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ceod/api/members.py
View File

@ -9,6 +9,7 @@ from ceo_common.errors import BadRequest, UserAlreadySubscribedError, UserNotSub
from ceo_common.interfaces import ILDAPService, IConfig, IMailService
from ceo_common.logger_factory import logger_factory
from ceo_common.model.Term import get_terms_for_new_user, get_terms_for_renewal
from ceo_common.utils import validate_username
from ceod.transactions.members import (
AddMemberTransaction,
ModifyMemberTransaction,
@ -30,6 +31,7 @@ def create_user():
body = request.get_json(force=True)
terms = body.get('terms')
non_member_terms = body.get('non_member_terms')
if (terms and non_member_terms) or not (terms or non_member_terms):
raise BadRequest('Must specify either terms or non-member terms')
if type(terms) is int:
@ -42,6 +44,10 @@ def create_user():
if type(body['forwarding_addresses']) is not list:
raise BadRequest('forwarding_addresses must be a list of email addresses')
uid_validator = validate_username(body['uid'])
if not uid_validator.is_valid:
raise BadRequest(f"bad uid: {uid_validator.error_message}")
if terms:
logger.info(f"Creating member {body['uid']} for terms {terms}")
else: