Use binary search for finding a new UID #36

New Issue

merenber · 2021-12-11T16:38:37-05:00

merenber commented

2021-12-11 16:38:37 -05:00

Currently, creating a new user with ceo on the CSC machines is quite slow. I suspect that the culprit is the _get_next_uid function in LDAPService.py, where we check every single UID from members_min_id until the next available UID.

We have a couple thousand records in our LDAP, so as you can imagine, this takes a very long time. It's also kind of dangerous to use pwd and grp because if a user was recently deleted, their entry will still be cached by nslcd, which can lead to all sorts of problems.

We should use binary search instead of linear search when trying to find the next available UID. This should be OK as long as we don't leave "gaps" in the UID number space (which I don't think we've ever done). When checking whether a UID number is available, we should always check LDAP directly (so we shouldn't be using pwd and grp anymore).

Currently, creating a new user with ceo on the CSC machines is quite slow. I suspect that the culprit is the `_get_next_uid` function in LDAPService.py, where we check *every single* UID from members_min_id until the next available UID. We have a couple thousand records in our LDAP, so as you can imagine, this takes a very long time. It's also kind of dangerous to use `pwd` and `grp` because if a user was recently deleted, their entry will still be cached by nslcd, which can lead to all sorts of problems. We should use binary search instead of linear search when trying to find the next available UID. This *should* be OK as long as we don't leave "gaps" in the UID number space (which I don't think we've ever done). When checking whether a UID number is available, we should always check LDAP directly (so we shouldn't be using `pwd` and `grp` anymore).

d278liu referenced a pull request that will close this issue

2021-12-23 12:54:56 -05:00

use binary search when finding new uid #39

merenber closed this issue

2021-12-23 17:00:29 -05:00

merenber referenced this issue from a commit

2021-12-23 17:00:30 -05:00

use binary search when finding new uid (#39)

Sign in to join this conversation.