Expire member cli and api #33
No reviewers
Labels
No Label
priority
high
priority
low
priority
medium
priority
very high
BUG
Feature
High Priority
Low Priority
Medium Priority
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: public/pyceo#33
Loading…
Reference in New Issue
No description provided.
Delete Branch "expire-member"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #23
Still missing cli tests ;_;
WIP: Expire member cli and apito Expire member cli and api@merenber tests added
72e3fdbaf6
toed9dc28a2b
Looks great - please see comments for requested changes.
@ -33,6 +33,7 @@ class User:
is_club_rep: Union[bool, None] = None,
is_club: bool = False,
ldap3_entry: Union[ldap3.Entry, None] = None,
shadowExpire: bool = False,
This should be an integer. shadowExpire is a Unix epoch timestamp.
@ -155,6 +158,7 @@ class User:
mail_local_addresses=attrs.get('mailLocalAddress'),
is_club_rep=attrs.get('isClubRep', [False])[0],
is_club=('club' in attrs['objectClass']),
shadowExpire=attrs.get('shadowExpire', 0) != 0,
See comment above.
@ -4,3 +4,4 @@ wheel==0.36.2
pytest==6.2.4
aiosmtpd==1.4.2
aiohttp==3.7.4.post0
freezegun==1.1.0
If you merge the current master branch, you'll see that the Term class now uses a
get_current_datetime
function which can be mocked out using the standardpatch
function in the Python unittest library. (There are some tests which already use this which you can as examples.)Could we please use this instead? Sorry for the late notice.
@ -12,3 +14,3 @@
@pytest.fixture(scope='module')
@pytest.fixture(scope='function')
I added a
new_user
pytest fixture in conftest.py. Could you use that instead of changing the scope of this fixture?6a1628da1e
toe76731fb4b