Rewrite TUI #52

Merged
merenber merged 7 commits from tui-urwid into master 5 months ago
Owner

Closes #44.
Closes #47.
Closes #49.
Closes #50.

The TUI has been rewritten using urwid instead of asciimatics. The MVC pattern was also used to help increase organization and readability.

The mouse has been disabled, which allows users to easily copy text from the terminal.

Terms are now sorted when displayed, for both the CLI and the TUI.

Closes #44. Closes #47. Closes #49. Closes #50. The TUI has been rewritten using urwid instead of asciimatics. The MVC pattern was also used to help increase organization and readability. The mouse has been disabled, which allows users to easily copy text from the terminal. Terms are now sorted when displayed, for both the CLI and the TUI.
merenber added 3 commits 5 months ago
merenber added 1 commit 5 months ago
6a60b5242f update some dependencies
merenber requested review from r389li 5 months ago
merenber requested review from n3parikh 5 months ago
Poster
Owner

There's a preview on corn-syrup if you want to test it out:

cd /scratch/merenber/pyceo
. venv/bin/activate
ceo
There's a preview on corn-syrup if you want to test it out: ``` cd /scratch/merenber/pyceo . venv/bin/activate ceo ```
merenber added 1 commit 5 months ago
643be9d5e1 allow PlainTextView to be scrollable
merenber requested review from r345liu 5 months ago
Owner

Tried it on corn-syrup and is working. Functionality wise it LGTM.

The weird grid pattern in the background when terminal size is too big renders pretty badly on my screen (probably doesn't show in the screenshot). Does urwid only support fixed size? If making the tui responsive isn't possible, can the background colour be changed to a more solid one?

image

Also, clearning the terminal after quitting might not be a bad idea.

Tried it on corn-syrup and is working. Functionality wise it LGTM. The weird grid pattern in the background when terminal size is too big renders pretty badly on my screen (probably doesn't show in the screenshot). Does urwid only support fixed size? If making the tui responsive isn't possible, can the background colour be changed to a more solid one? ![image](/attachments/4c528b1a-f218-4cf8-94fd-d1d7e5861bcd) Also, clearning the terminal after quitting might not be a bad idea.
merenber added 1 commit 5 months ago
fe27ee7259 change background to light cyan
merenber added 1 commit 5 months ago
0dd53b0821 fix ColumnResponseView formatting
Poster
Owner

Background was changed to light cyan.
Also fixed some formatting issues.

Background was changed to light cyan. Also fixed some formatting issues.
Owner

Yep that looks a lot better now. LGTM

Yep that looks a lot better now. LGTM
merenber merged commit b543f0eb0c into master 5 months ago
merenber deleted branch tui-urwid 5 months ago
merenber referenced this issue from a commit 5 months ago

Reviewers

r389li was requested for review 5 months ago
n3parikh was requested for review 5 months ago
r345liu was requested for review 5 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as b543f0eb0c.
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: public/pyceo#52
Loading…
There is no content yet.