Positions API #7

Merged
r345liu merged 13 commits from positions-api into v1 1 year ago
r345liu commented 1 year ago
Owner

Haven't got tests working yet, but the main codes should be there.

Haven't got tests working yet, but the main codes should be there.
r345liu added 7 commits 1 year ago
r345liu force-pushed positions-api from 1a9d4755cb to 0ed876c010 1 year ago
r345liu changed title from Positions API to WIP: Positions API 1 year ago
merenber added 2 commits 1 year ago
Owner

@r345liu Excellent work. Just a few minor adjustments. And, of course, unit tests.

@r345liu Excellent work. Just a few minor adjustments. And, of course, unit tests.
merenber added 2 commits 1 year ago
merenber added 1 commit 1 year ago
ca3ada5886 add failed_to_subscribe_to_mailing_lists
r345liu changed title from WIP: Positions API to Positions API 1 year ago
r345liu reviewed 1 year ago
return False
if section.startswith('auxiliary '):
return val.split(',')
if section.startswith('auxiliary ') or section == 'positions':
Poster
Owner

What is the difference between auxiliary and non-auxiliary configs? Because if we use "auxiliary positions" as the section key then a special case wouldn't be needed here.

What is the difference between auxiliary and non-auxiliary configs? Because if we use "auxiliary positions" as the section key then a special case wouldn't be needed here.
Owner

Anything 'auxiliary' is supposed to be 'supplementary'. For example, 'auxiliary groups' are the supplementary groups to which a user should be added when they are added to a main group.

Unfortunately INI files don't allow us to specify data types, and we can't use a comma as a general-case delimiter since the LDAP bases contain commas. So we'll just have to check the name of the section on a case-by-case basis.

Anything 'auxiliary' is supposed to be 'supplementary'. For example, 'auxiliary groups' are the supplementary groups to which a user should be added when they are added to a main group. Unfortunately INI files don't allow us to specify data types, and we can't use a comma as a general-case delimiter since the LDAP bases contain commas. So we'll just have to check the name of the section on a case-by-case basis.
r345liu marked this conversation as resolved
r345liu merged commit ad937eebeb into v1 1 year ago
r345liu referenced this issue from a commit 1 year ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as ad937eebeb.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: public/pyceo#7
Loading…
There is no content yet.