public
/
pyceo
27
1
Fork 3
Code Issues 25 Pull Requests 5 Projects Releases 1 Wiki Activity

Sort group member listing by WatIAM ID #78

Merged
r389li merged 4 commits from :master into master 2022-10-13 14:58:51 -04:00
Conversation 0 Commits 4 Files Changed 1 +2 -2
j23leung commented 2022-10-12 02:41:11 -04:00
Member
Copy Link

Closes #74.

Closes #74.
j23leung self-assigned this 2022-10-12 02:41:11 -04:00
j23leung added 1 commit 2022-10-12 02:41:13 -04:00
j23leung added 1 commit 2022-10-12 02:41:24 -04:00
r389li requested changes 2022-10-12 12:58:12 -04:00
ceod/model/Group.py Outdated
@ -64,6 +64,7 @@ class Group:
# to_dict() is usually called for display purposes, so get some more
# information to display
data['members'] = self.ldap_srv.get_display_info_for_users(self.members)
data['members'].sort(key=lambda member: member['uid'])
r389li commented 2022-10-12 12:58:04 -04:00
Owner
Copy Link

Let's sort higher up (in get_display_info_for_users), I think that can be helpful in case we reuse that function for it to be consistent.

Let's sort higher up (in `get_display_info_for_users`), I think that can be helpful in case we reuse that function for it to be consistent.
j23leung marked this conversation as resolved
j23leung added 1 commit 2022-10-12 18:15:07 -04:00
j23leung requested review from r389li 2022-10-12 18:18:14 -04:00
j23leung was unassigned by r389li 2022-10-13 00:17:45 -04:00
r389li requested changes 2022-10-13 00:19:22 -04:00
r389li left a comment
Owner
Copy Link

Almost there!

Almost there!
ceod/model/LDAPService.py Outdated
@ -113,3 +113,3 @@
attributes = ['uid', 'cn', 'program']
conn.search(self.ldap_users_base, filter, attributes=attributes)
return [
entries = [
r389li commented 2022-10-13 00:19:06 -04:00
Owner
Copy Link

Can we use sorted to make the code cleaner and avoid an explicit .sort() call and extra variable?

Can we use `sorted` to make the code cleaner and avoid an explicit `.sort()` call and extra variable?
j23leung marked this conversation as resolved
j23leung added 1 commit 2022-10-13 00:23:27 -04:00
j23leung requested review from r389li 2022-10-13 01:30:02 -04:00
r389li approved these changes 2022-10-13 01:31:56 -04:00
r389li left a comment
Owner
Copy Link

Perfect, LGTM :)

Perfect, LGTM :)
j23leung scheduled this pull request to auto merge when all checks succeed 2022-10-13 01:46:37 -04:00
r389li merged commit c30ca54752 into master 2022-10-13 14:58:51 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
r389li
Labels
Clear labels   
priority
high
High priority

  
priority
low
Low priority

  
priority
medium
Medium priority

  
priority
very high
Very high priority

  
BUG

   
Feature

   
High Priority

   
Low Priority

   
Medium Priority
No Label
priority
high
priority
low
priority
medium
priority
very high
BUG
Feature
High Priority
Low Priority
Medium Priority
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: public/pyceo#78
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?