Sort group member listing by WatIAM ID #78
No reviewers
Labels
No Label
priority
high
priority
low
priority
medium
priority
very high
BUG
Feature
High Priority
Low Priority
Medium Priority
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: public/pyceo#78
Loading…
Reference in New Issue
No description provided.
Delete Branch ":master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #74.
@ -64,6 +64,7 @@ class Group:
# to_dict() is usually called for display purposes, so get some more
# information to display
data['members'] = self.ldap_srv.get_display_info_for_users(self.members)
data['members'].sort(key=lambda member: member['uid'])
Let's sort higher up (in
get_display_info_for_users
), I think that can be helpful in case we reuse that function for it to be consistent.Almost there!
@ -113,3 +113,3 @@
attributes = ['uid', 'cn', 'program']
conn.search(self.ldap_users_base, filter, attributes=attributes)
return [
entries = [
Can we use
sorted
to make the code cleaner and avoid an explicit.sort()
call and extra variable?Perfect, LGTM :)