Implement TUI support for multiple users in each position #80

													
				@ -18,6 +22,7 @@ class SetPositionsController(Controller):

				        for pos, field in self.view.position_fields.items():

				            if field.edit_text != '':

				                body[pos] = field.edit_text

				        logger.info(body)

r389li commented

2022-10-13 23:47:42 -04:00

Will this clutter up log?

j24chung commented

2022-10-14 13:12:44 -04:00

Not sure why but this piece of code isn't supposed to be in the branch anymore. I don't see it on my local repo which should be in sync with the branch being merged. I'll look into why it isn't gone yet.

j24chung commented

2022-10-14 13:21:58 -04:00

Fixed :)

j24chung marked this conversation as resolved

ceod/transactions/members/UpdateMemberPositionsTransaction.py Outdated

													
				@ -32,0 +35,4 @@

				                for user in username:

				                    self.positions[user].append(position)

				            else:

				                raise TypeError("Username(s) under each position must either be a string or a list")

r389li commented

2022-10-14 00:24:41 -04:00

Would the rest of this file work as well? On a cursory glance there's a couple more places that look like they should need changing (i.e. removing old positions, etc.)

Also, let's add some tests specifically targetting this, so we can future-proof guarantees of it working!

Would the rest of this file work as well? On a cursory glance there's a couple more places that look like they should need changing (i.e. removing old positions, etc.) Also, let's add some tests specifically targetting this, so we can future-proof guarantees of it working!

j24chung commented

2022-10-14 13:29:41 -04:00

Could you clarify on what places need more changing? Not very sure about the whole code design but all I've changed is that when a position has a list of userids, instead of just a string of one user's userid, it will know how to parse that list and add the position to each user. I assume the remaining code knows how to handle a case where one user has multiple positions, as required

j24chung commented

2022-10-14 13:30:36 -04:00

I could def add tests targeting this new feature!

r345liu commented

2022-11-26 20:49:28 -05:00

I think this is the only other place that needs to be updated


            self.old_positions[username] = old_positions
            for position in new_positions:
                new_positions_reversed[position] = username

Also, I think the ceod api is the only place using UpdateMemberPositionsTransaction, so you can just change the type without needing to care about string

I think this is the only other place that needs to be updated ```python self.old_positions[username] = old_positions for position in new_positions: new_positions_reversed[position] = username ``` Also, I think the ceod api is the only place using `UpdateMemberPositionsTransaction`, so you can just change the type without needing to care about string

j24chung added 1 commit 2022-10-14 13:21:23 -04:00

continuous-integration/drone/pr Build is failing Details

910449d67a

Remove some logging code

j24chung added 1 commit 2022-10-14 13:36:48 -04:00

continuous-integration/drone/pr Build is passing Details

4145491373

Fix linting error

merenber added 2 commits 2023-01-23 02:15:26 -05:00

d6ce40037d Merge branch 'master' into feature-59

continuous-integration/drone/pr Build is passing Details

dbe1ef4d09 use list to represent multiple users for a given position