Rio Liu r345liu
  • Joined on 2021-07-31
r345liu commented on pull request public/pyceo#86 2022-11-27 10:25:39 -05:00
Add linting pre-commit hook and hook install script

I think we can assume git commit would be running inside virtual env, plus venv directory can be located elsewhere too

r345liu suggested changes for public/pyceo#86 2022-11-26 20:57:24 -05:00
Add linting pre-commit hook and hook install script

Might want to consider the case where file name can be white space. Just adding a IFS='\n' before the for loop is probably enough.

r345liu commented on pull request public/pyceo#80 2022-11-26 20:49:28 -05:00
Implement TUI support for multiple users in each position

I think this is the only other place that needs to be updated


            self.old_positions[username] = old_positions
            for position in new_positions:
               
r345liu created pull request public/pyceo#77 2022-10-06 10:49:22 -04:00
Add support for using number in member terms renwewal API
r345liu pushed to number-renewal at public/pyceo 2022-10-06 10:44:27 -04:00
625b129e5e numerical renewal adds to current term if last term is in the past
r345liu commented on issue public/pyceo#75 2022-10-06 10:26:06 -04:00
Allow renewing and adding new users by number of terms

behaviuor of get_terms_for_renewal would be w2023 so I'll make it do that.

side note: get_terms_for_renewal function is written for client so is not suitable for server side use

r345liu commented on issue public/pyceo#75 2022-10-06 10:18:11 -04:00
Allow renewing and adding new users by number of terms

Say if a user has terms

f2020
w2021

and current term is f2022

should adding 1 term add w2023 or s2021?

r345liu pushed to number-renewal at public/pyceo 2022-10-06 10:16:42 -04:00
301aaeb548 add support for specifying number of renwal term in as number
r345liu pushed to number-renewal at public/pyceo 2022-10-05 10:55:53 -04:00
b4e21259a3 fix get_terms_for_renewal import
r345liu created branch number-renewal in public/pyceo 2022-10-02 11:05:18 -04:00
r345liu pushed to number-renewal at public/pyceo 2022-10-02 11:05:18 -04:00
1c0399a4b5 add support to use number of terms in /members/renew endpoint
r345liu approved public/pyceo#68 2022-07-12 21:26:28 -04:00
Disable inactive club sites
r345liu commented on pull request public/pyceo#52 2022-05-22 11:35:19 -04:00
Rewrite TUI

Yep that looks a lot better now. LGTM

r345liu commented on pull request public/pyceo#52 2022-05-21 10:36:48 -04:00
Rewrite TUI

Tried it on corn-syrup and is working. Functionality wise it LGTM.

The weird grid pattern in the background when terminal size is too big renders pretty badly on my screen (probably doesn't…

r345liu created pull request public/pyceo#53 2022-05-16 22:03:42 -04:00
Unsubscribe/resubscribe members when they're expired and renewed
r345liu pushed to expire-unsubscribe at public/pyceo 2022-05-16 21:53:05 -04:00
01046016fe ignore subscription errors when sub/unsubbing for expiring members
r345liu created branch expire-unsubscribe in public/pyceo 2022-05-16 21:15:18 -04:00
r345liu pushed to expire-unsubscribe at public/pyceo 2022-05-16 21:15:18 -04:00
b939eab1e1 unsubscribe from csc general when shadow expiring member, and resubscribe when renewed
r345liu created pull request public/mirror-checker#9 2022-04-14 14:01:50 -04:00
Update time stamp parsing in cran, ctan, mxlinux
r345liu pushed to time-parsing at public/mirror-checker 2022-04-14 13:57:14 -04:00
789f0cd662 update time stamp parsing in cran, ctan, mxlinux