Commit Graph

6 Commits

Author SHA1 Message Date
Darren Lo 3ffa2a9f74 darren/chart-formatting (#175)
continuous-integration/drone/push Build is passing Details
Closes #140 kind of.

Co-authored-by: DarrenLo0530 <darren.lo.0530@gmail.com>
Co-authored-by: dlslo <dlslo@uwaterloo.ca>
Co-authored-by: shahanneda <shahan.neda@gmail.com>
Reviewed-on: #175
Reviewed-by: Shahan Nedadahandeh <snedadah@csclub.uwaterloo.ca>
Co-authored-by: Darren Lo <dlslo@csclub.uwaterloo.ca>
Co-committed-by: Darren Lo <dlslo@csclub.uwaterloo.ca>
2023-02-13 18:36:23 -05:00
Shahan Nedadahandeh 743f050ec8 Fix tooltip not being correctly positioned for certain centered graphs (#118)
continuous-integration/drone/push Build is passing Details
Applied the fix used by the WordCloud to all graphs so that tooltips will be properly positioned, even if the graph is centered on the page. Did so by refactoring some tooltip logic in to a common getTooltipPosition used by all graphs.

One thing is that this simplifies all the tooltips to simply follow the mouse, instead of locking onto certain "blocks"/bars like in the grouped bar graph, which is more consitant with all the other tooltips, since we only had this in some cases.

Do we think that having the tooltip be sticky to a certain bar/group is important?

Closes #89

https://fix-tooltip-center-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/
Co-authored-by: shahanneda <shahan.neda@gmail.com>
Reviewed-on: #118
Reviewed-by: Mark Chiu <e26chiu@csclub.uwaterloo.ca>
2022-12-28 01:54:32 -05:00
Shahan Nedadahandeh b8590f7a28 Adjust pie chart (#117)
continuous-integration/drone/push Build is passing Details
https://adjust-pie-1-csc-class-profile-staging-snedadah.k8s.csclub.cloud/academics/
Co-authored-by: shahanneda <shahan.neda@gmail.com>
Co-authored-by: Mark Chiu <e26chiu@csclub.uwaterloo.ca>
Reviewed-on: #117
Reviewed-by: Mark Chiu <e26chiu@csclub.uwaterloo.ca>
2022-12-28 01:32:07 -05:00
Mark Chiu 519f925155 Add Personal Page (Closes #62) (#113)
continuous-integration/drone/push Build is passing Details
Removed P1 because it was crossed out in https://docs.google.com/document/d/12x1HqxwXJ4WW2K1grtZwUTc8kMcyIHvbHOafD1NEO6M/edit#heading=h.9iho523v97l0

We can add it back if we want to; it could be an entertaining section to read.

We have some NSFW quotes. They have been filtered/censored/sorted to the end.

Co-authored-by: e26chiu <e26chiu@csc.uwaterloo.ca>
Reviewed-on: #113
Reviewed-by: Shahan Nedadahandeh <snedadah@csclub.uwaterloo.ca>
2022-12-21 23:20:25 -05:00
Mark Chiu 550029feb0 Change Graphs to use tooltips (Closes #97) (#112)
continuous-integration/drone/push Build is passing Details
Changes:
- Remove Text that is displayed when hovering over the bar in the Bar Graph and Grouped Bar Graph - DIDN'T DO IT FOR Pie Charts since I wasn't sure if we still want the text or no.
- Add tooltips for Bar Graph + Grouped Bar Graph + Pie Chart

NOTE: weird tooltip position with PieChart, might be related to other tooltip bugs we have

Used this approach for the PieChart: https://codesandbox.io/s/mjp8lmvop?expanddevtools=1
The only approach that worked with the PieChart required to have the PieSlice code within the PieChart component.

Improvement we can make:
- For the Pie Chart, we could display the percentage and the number of answers in the tooltip to provide more context.
- For the Pie Chart, we could also display label in tooltip.

Co-authored-by: e26chiu <e26chiu@csc.uwaterloo.ca>
Reviewed-on: #112
Reviewed-by: Shahan Nedadahandeh <snedadah@csclub.uwaterloo.ca>
2022-12-21 16:23:32 -05:00
Jared He 9200e5f491 Pie chart component (#19)
continuous-integration/drone/push Build is passing Details
Closes #5.

To fix:

- [x] Inner pie slice text not perfectly centered

- [x] Create optional props for `padRadius` and `innerRadius`

- [x] Change colors to global colors and merge from main to get fonts

Also, outer labels can get cut off if they are long enough, but the `labelWidth` is provided as a prop for the user to adjust.

Staging url: https://j285he-pie-chart-csc-class-profile-staging-snedadah.k8s.csclub.cloud

Co-authored-by: Jared He <66887902+jaredjhe@users.noreply.github.com>
Reviewed-on: #19
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
2022-09-07 22:20:30 -04:00