www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Added default word cloud width util #102

Merged
snedadah merged 2 commits from shahanneda/wordcloudwidth into main 2022-12-04 16:22:07 -05:00
Conversation 0 Commits 2 Files Changed 2 +14 -19
snedadah commented 2022-12-02 16:30:32 -05:00
Owner
Copy Link
No description provided.
snedadah added 1 commit 2022-12-02 16:30:33 -05:00
continuous-integration/drone/push Build is failing Details
ca15214291 Added default word cloud width util
snedadah requested review from e26chiu 2022-12-02 16:30:42 -05:00
snedadah reviewed 2022-12-02 16:31:36 -05:00
utils/defaultProps.ts Outdated
@ -12,2 +18,3 @@
? pageWidth / mobilePieChartFactor
: pageWidth / desktopPieChartFactor;
const graphWidth = (
snedadah commented 2022-12-02 16:31:36 -05:00
Author
Owner
Copy Link

I think that this function isnt really needed anymore. Since it doesn't really make sense to add a whole other boolean saying "isWordCloud". Just having seperate functions is a good enough abstraction imo.

I think that this function isnt really needed anymore. Since it doesn't really make sense to add a whole other boolean saying "isWordCloud". Just having seperate functions is a good enough abstraction imo.
👍 1
snedadah added 1 commit 2022-12-02 16:32:29 -05:00
continuous-integration/drone/push Build is passing Details
9532c97035 Fixed typo type
e26chiu approved these changes 2022-12-03 20:11:08 -05:00
e26chiu left a comment
Contributor
Copy Link

LGTM! 🚀 🚀 🚀

LGTM! 🚀 🚀 🚀
snedadah merged commit 3dd978c67e into main 2022-12-04 16:22:07 -05:00
snedadah deleted branch shahanneda/wordcloudwidth 2022-12-04 16:22:07 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#102
No description provided.
Delete Branch "shahanneda/wordcloudwidth"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?