www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Fix Line Graph Legend Position (Close #100) #107

Merged
b72zhou merged 5 commits from b72zhou-line-graph-legend into main 2022-12-14 11:14:50 -05:00
Conversation 0 Commits 5 Files Changed 3 +15 -6993
b72zhou commented 2022-12-11 19:17:51 -05:00
Contributor
Copy Link
No description provided.
b72zhou added 1 commit 2022-12-11 19:17:52 -05:00
continuous-integration/drone/push Build is passing Details
72ad473050 :fix: legend
b72zhou added 1 commit 2022-12-11 19:19:26 -05:00
continuous-integration/drone/push Build is passing Details
cccfac319e Merge branch 'main' into b72zhou-line-graph-legend
b72zhou changed title from Fix Line Graph Legend Position to Fix Line Graph Legend Position (Close #100) 2022-12-11 19:20:14 -05:00
b72zhou requested review from e26chiu 2022-12-11 19:21:48 -05:00
e26chiu added 1 commit 2022-12-11 22:11:44 -05:00
continuous-integration/drone/push Build is passing Details
2e5ffabf08 Get rid of unused vars + center legend
e26chiu approved these changes 2022-12-11 22:15:11 -05:00
e26chiu left a comment
Contributor
Copy Link

I got rid of other unused variables/props in the component. I also modified the LineGraph legend so that it is only displayed centered at a fixed space from the graph because I found it more simple than having a left and top offset of the graph and legend. Let me know if that is good with you @b72zhou Otherwise, LGTM! 🚀

I got rid of other unused variables/props in the component. I also modified the LineGraph legend so that it is only displayed centered at a fixed space from the graph because I found it more simple than having a left and top offset of the graph and legend. Let me know if that is good with you @b72zhou Otherwise, LGTM! 🚀
👍 1
e26chiu approved these changes 2022-12-12 18:54:10 -05:00
e26chiu left a comment
Contributor
Copy Link

I just noticed a small thing.

I just noticed a small thing.
components/LineGraph.tsx Outdated
@ -183,3 +129,1 @@
flexDirection: legendPosition === "right" ? "row" : "column-reverse",
}}
>
<div className={styles.container}>
e26chiu commented 2022-12-12 18:52:32 -05:00
Contributor
Copy Link

What is styles.container for? Where is the container class?

What is `styles.container` for? Where is the `container` class?
b72zhou commented 2022-12-13 21:00:19 -05:00
Author
Contributor
Copy Link

sry a class was there but deleted, got rid of it

sry a class was there but deleted, got rid of it
👍 1
b72zhou added 1 commit 2022-12-13 20:59:19 -05:00
continuous-integration/drone/push Build is passing Details
e1eb3c24f8 :chore: minor fix
b72zhou added 1 commit 2022-12-13 21:02:14 -05:00
continuous-integration/drone/push Build is passing Details
e0c9ce77eb Merge branch 'main' into b72zhou-line-graph-legend
b72zhou merged commit 2720728e46 into main 2022-12-14 11:14:50 -05:00
b72zhou deleted branch b72zhou-line-graph-legend 2022-12-14 11:14:51 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#107
No description provided.
Delete Branch "b72zhou-line-graph-legend"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?