www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Style scrollbar #119

Merged
snedadah merged 5 commits from add-scrollbar into main 2022-12-29 03:43:08 -05:00
Conversation 0 Commits 5 Files Changed 2 +18 -3
snedadah commented 2022-12-28 01:56:31 -05:00
Owner
Copy Link

Styles scrollbar

Styles scrollbar
snedadah added 3 commits 2022-12-28 01:56:32 -05:00
continuous-integration/drone/push Build is passing Details
96bdea5557 Add custom scroll bar styles
continuous-integration/drone/push Build is passing Details
b8763a680a cleaned up
snedadah requested review from e26chiu 2022-12-28 01:56:47 -05:00
e26chiu approved these changes 2022-12-28 22:44:16 -05:00
e26chiu left a comment
Contributor
Copy Link

LGTM! @snedadah ! I like that the colour is still different from the generic background so we can differentiate the scrollbar a bit. It fits the overall theme of the website though!

LGTM! @snedadah ! I like that the colour is still different from the generic background so we can differentiate the scrollbar a bit. It fits the overall theme of the website though!
components/Header.module.css Outdated
@ -35,3 +35,2 @@
composes: sideBarCommon;
/* -1% to hide slight line tip showing in some browsers */
transform: translateX(-1%);
transform: translateX(0);
e26chiu commented 2022-12-28 22:42:21 -05:00
Contributor
Copy Link

I think we can also remove this since by default it would show. I tried removing it and the sidebar navigation seems to work well (when toggling).

I think we can also remove this since by default it would show. I tried removing it and the sidebar navigation seems to work well (when toggling).
snedadah added 1 commit 2022-12-29 03:00:26 -05:00
continuous-integration/drone/push Build was killed Details
8896786732 Styled scrollbar
snedadah added 1 commit 2022-12-29 03:01:10 -05:00
continuous-integration/drone/push Build is passing Details
145b78cb3c Extra space
snedadah merged commit fbb0ca25ac into main 2022-12-29 03:43:08 -05:00
snedadah deleted branch add-scrollbar 2022-12-29 03:43:08 -05:00
snedadah referenced this issue from a commit 2022-12-29 03:43:09 -05:00
Style scrollbar (#119)
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#119
No description provided.
Delete Branch "add-scrollbar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?