www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Fix StackedBar Graph nitpicks (Closes #51) #133

Merged
e26chiu merged 9 commits from fix-stackedbar-graph into main 2023-01-03 13:51:47 -05:00
Conversation 0 Commits 9 Files Changed 5 +141 -182
e26chiu commented 2023-01-02 00:18:08 -05:00
Contributor
Copy Link

Decided not to fix NITPICK #1 because aligning the line with the edge of the graph can make the grid column gap seem bigger than intended.

  • Center align bottom axis labels in both horizontal and vertical graphs
  • Right align left axis labels in both horizontal and vertical graphs
  • Fixed Cumulative Average to CAV in Academics page.
  • Add line at the top of the horizontal graph
Decided not to fix NITPICK #1 because aligning the line with the edge of the graph can make the grid column gap seem bigger than intended. - Center align bottom axis labels in both horizontal and vertical graphs - Right align left axis labels in both horizontal and vertical graphs - Fixed Cumulative Average to CAV in Academics page. - Add line at the top of the horizontal graph
e26chiu added 5 commits 2023-01-02 00:18:10 -05:00
continuous-integration/drone/push Build is passing Details
05f0f9f7e0 Fix Stacked Bar Graph nitpicks
snedadah added 1 commit 2023-01-02 14:51:47 -05:00
continuous-integration/drone/push Build is passing Details
b49b7a1c2c Adjusted playground
snedadah reviewed 2023-01-02 14:52:53 -05:00
snedadah left a comment
Owner
Copy Link

LGTM!

For some reason this question was still a bit weird, but everything else is fine. I tried to fix it but I couln't 😢 so I think its okay to leave it since it sieems to work well everywhere else
image

LGTM! For some reason this question was still a bit weird, but everything else is fine. I tried to fix it but I couln't :cry: so I think its okay to leave it since it sieems to work well everywhere else ![image](/attachments/435338cf-69b4-4adb-9876-13b84eb46e29)
image.png
35 KiB
snedadah added 1 commit 2023-01-02 14:54:08 -05:00
continuous-integration/drone/push Build is passing Details
c1ea18544a Merge branch 'main' into fix-stackedbar-graph
snedadah approved these changes 2023-01-02 15:59:41 -05:00
e26chiu added 2 commits 2023-01-03 12:10:39 -05:00
continuous-integration/drone/push Build is passing Details
e7fd4ee1a8 Get rid of axisLeftOffset
e26chiu merged commit eb74c8e4a9 into main 2023-01-03 13:51:47 -05:00
e26chiu deleted branch fix-stackedbar-graph 2023-01-03 13:51:47 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#133
No description provided.
Delete Branch "fix-stackedbar-graph"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?