Fix weird percentage number and add percent symbol #157

Merged
snedadah merged 3 commits from shahanneda/fix-percent into main 2023-01-31 00:36:50 -05:00
Owner

image

image

![image](/attachments/956151a0-270d-4d46-9985-73c24806e338) ![image](/attachments/f00e1266-8d16-46cd-9408-9955c93c3dd2)
snedadah added 1 commit 2023-01-28 14:30:36 -05:00
continuous-integration/drone/push Build is passing Details
00f3950106
Commited changes
snedadah requested review from e26chiu 2023-01-28 14:30:45 -05:00
e26chiu added 1 commit 2023-01-30 21:51:28 -05:00
continuous-integration/drone/push Build is passing Details
e4a1154032
Fix tooltip formatting + calibrate data
e26chiu approved these changes 2023-01-30 21:53:40 -05:00
e26chiu left a comment
Contributor

@snedadah I have only one question regarding hiding data value. I also added labels to other tooltips and adjusted the data for one of the stacked bar graph (from 0.01 to 1) to match the other percentages of data. Nothing blocking this from being merged though. Good job!

@snedadah I have only one question regarding hiding data value. I also added labels to other tooltips and adjusted the data for one of the stacked bar graph (from 0.01 to 1) to match the other percentages of data. Nothing blocking this from being merged though. Good job!
pages/coop.tsx Outdated
@ -231,6 +231,8 @@ export default function CoopPage() {
]}
data={C7v}
margin={barGraphMargin}
hideDataValueInTooltip
Contributor

I'm not sure I understand why we are hiding the data value for this specific graph tooltip?

I'm not sure I understand why we are hiding the data value for this specific graph tooltip?
Author
Owner

The original plan was to use hide this one, but then since I added the percentage option, which is better. So good point, I changed it to percentage (thanks for changing the data).

The original plan was to use hide this one, but then since I added the percentage option, which is better. So good point, I changed it to percentage (thanks for changing the data).
snedadah added 1 commit 2023-01-30 22:21:13 -05:00
continuous-integration/drone/push Build is passing Details
bc3f8d5eaa
Changed hide to percentage
snedadah merged commit 1a6d031dd6 into main 2023-01-31 00:36:50 -05:00
snedadah deleted branch shahanneda/fix-percent 2023-01-31 00:36:50 -05:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#157
No description provided.