www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Recopied academics page #168

Merged
snedadah merged 1 commits from shahaneda/academics-page-recopy into main 2023-02-05 12:26:16 -05:00
Conversation 0 Commits 1 Files Changed 1 +88 -25
snedadah commented 2023-02-04 02:36:14 -05:00
Owner
Copy Link

https://shahaneda-academics-page-recopy-csc-class-pr-snedadah.k8s.csclub.cloud/academics/

https://shahaneda-academics-page-recopy-csc-class-pr-snedadah.k8s.csclub.cloud/academics/
snedadah added 1 commit 2023-02-04 02:36:15 -05:00
continuous-integration/drone/push Build is passing Details
d1d2535c17 Recopeid academics page
snedadah requested review from e26chiu 2023-02-04 02:36:25 -05:00
snedadah changed title from Recopeid academics page to Recopied academics page 2023-02-04 02:39:56 -05:00
e26chiu approved these changes 2023-02-04 13:02:28 -05:00
e26chiu left a comment
Contributor
Copy Link

I'm assuming the entire page has been copied and corrected. Everything LGTM, just a small formatting issue perhaps?

I'm assuming the entire page has been copied and corrected. Everything LGTM, just a small formatting issue perhaps?
pages/academics.tsx
@ -225,3 +288,3 @@
<ComponentWrapper
heading="Who is your favourite professor in all of UW?"
bodyText="Class of 2022 would like to give a shout out to Alice Gao, Carmen Bruni, and Lesley Istead as best professors in UW! Go read their ratings on UWFlow! ;) We would also like to give an honourable mention to every profs and TAs part of the Math faculty who have poured their passion in teaching to help the CS class of 2022 grow and succeed! You guys are amazing! ❤️"
bodyText="The class of 2022 would like to give a shout out to Alice Gao, Carmen Bruni, Lesley Istead, and Brad Lushman as some of the best professors at UW! Go read their ratings on UWFlow! We would also like to give an honourable mention to every professor who has poured their passion into teaching. This has helped the CS Class of 2022 grow and succeed! You guys are all amazing! ❤️"
e26chiu commented 2023-02-04 12:59:53 -05:00
Contributor
Copy Link

Is there an emoji that is not displaying correctly? I'm seeing [U+FE0F] in red displayed after the heart emoji. There is also a warning sign next to this line.

In the actual staging site, everything is displayed up until the heart emoji.

Is there an emoji that is not displaying correctly? I'm seeing `[U+FE0F]` in red displayed after the heart emoji. There is also a warning sign next to this line. In the actual staging site, everything is displayed up until the heart emoji.
snedadah commented 2023-02-05 12:26:07 -05:00
Author
Owner
Copy Link

Thats just a modifer for the emoji (special color or something). Its not anything else.

Thats just a modifer for the emoji (special color or something). Its not anything else.
snedadah merged commit 41066af334 into main 2023-02-05 12:26:16 -05:00
snedadah deleted branch shahaneda/academics-page-recopy 2023-02-05 12:26:16 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#168
No description provided.
Delete Branch "shahaneda/academics-page-recopy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?