Fixed data and tooltip issues with wordcloud #84

Merged
snedadah merged 11 commits from fix-wordcloud-data into main 2022-11-13 23:20:59 -05:00
Owner

Closes #80
Closes #78

Added finer control for word cloud min/max font sizes. Changed defaults to be a bit more sensible, and also adjusted the values for the demographics page word cloud to display all data (main culprit was "wordPadding" was too big)
Added a console.error for when not all the words are being display to aid in development for when we're adjusting the min/max font sizes.
Fixed word cloud tooltip not being correct on centered word clouds.
Added a min width to the word cloud, aniticipating changes from #85

https://fix-wordcloud-data-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/

https://fix-wordcloud-data-csc-class-profile-staging-snedadah.k8s.csclub.cloud/demographics/

Closes #80 Closes #78 Added finer control for word cloud min/max font sizes. Changed defaults to be a bit more sensible, and also adjusted the values for the demographics page word cloud to display all data (main culprit was "wordPadding" was too big) Added a console.error for when not all the words are being display to aid in development for when we're adjusting the min/max font sizes. Fixed word cloud tooltip not being correct on centered word clouds. Added a min width to the word cloud, aniticipating changes from #85 https://fix-wordcloud-data-csc-class-profile-staging-snedadah.k8s.csclub.cloud/samplePage/ https://fix-wordcloud-data-csc-class-profile-staging-snedadah.k8s.csclub.cloud/demographics/
snedadah added 8 commits 2022-11-12 15:44:44 -05:00
continuous-integration/drone/push Build is failing Details
5e813c233b
Added seprate font sizes on mobile
continuous-integration/drone/push Build is failing Details
48e430095a
Changed default mobile word cloud size
continuous-integration/drone/push Build is failing Details
8877db62a7
Adjusted demographics word cloud
continuous-integration/drone/push Build is failing Details
3ce89f1cc5
Fixed centered word cloud tooltip alignment
continuous-integration/drone/push Build is passing Details
3439b1b57d
Undid temp comment
continuous-integration/drone/push Build is passing Details
54b513447c
Removed uneeded default
snedadah added 2 commits 2022-11-12 15:46:27 -05:00
continuous-integration/drone/push Build is passing Details
1e370048f9
Added min width
snedadah requested review from e26chiu 2022-11-12 16:11:42 -05:00
e26chiu approved these changes 2022-11-13 20:24:49 -05:00
e26chiu left a comment
Contributor

@snedadah Code mostly LGTM! I like the fix on the tooltip with the offset so that it doesn't go out of bounds. NITPICKS: The WordCloud for the Demographics page looks a bit cramped on Desktop. We can up the wordPadding probably a little bit. There is also a bit of space in the mobile version (see attached image)

image

There is still the possibility that the WordCloud can overflow on Desktop while resizing the window although we can adjust the props (wordPadding, desktopMinFontSize, etc.) to make it fit.
Note to be fixed in future PR: WordCloud + text at screen width 1100px is not the most visually appealing.

@snedadah Code mostly LGTM! I like the fix on the tooltip with the offset so that it doesn't go out of bounds. NITPICKS: The WordCloud for the Demographics page looks a bit cramped on Desktop. We can up the wordPadding probably a little bit. There is also a bit of space in the mobile version (see attached image) ![image](/attachments/ce194fbe-da4b-4668-a86e-802b0c9f2635) There is still the possibility that the WordCloud can overflow on Desktop while resizing the window although we can adjust the props (wordPadding, desktopMinFontSize, etc.) to make it fit. Note to be fixed in future PR: WordCloud + text at screen width 1100px is not the most visually appealing.
@ -0,0 +1,7 @@
let inDevEnvironment = false;
Contributor
let inDevEnvironment = process && process.env.NODE_ENV === "development"

We can also write it this way to make it more concise?

```suggestion let inDevEnvironment = process && process.env.NODE_ENV === "development" ``` We can also write it this way to make it more concise?
Author
Owner

T

@snedadah Code mostly LGTM! I like the fix on the tooltip with the offset so that it doesn't go out of bounds. NITPICKS: The WordCloud for the Demographics page looks a bit cramped on Desktop. We can up the wordPadding probably a little bit. There is also a bit of space in the mobile version (see attached image)

image

There is still the possibility that the WordCloud can overflow on Desktop while resizing the window although we can adjust the props (wordPadding, desktopMinFontSize, etc.) to make it fit.
Note to be fixed in future PR: WordCloud + text at screen width 1100px is not the most visually appealing.

The word cloud doesn't actually overflow, it just doesnt resize. If you refresh the page after resizing it should be fixed. I'm not sure why it doesn't fix it self when resizing :(

T > @snedadah Code mostly LGTM! I like the fix on the tooltip with the offset so that it doesn't go out of bounds. NITPICKS: The WordCloud for the Demographics page looks a bit cramped on Desktop. We can up the wordPadding probably a little bit. There is also a bit of space in the mobile version (see attached image) > > ![image](/attachments/ce194fbe-da4b-4668-a86e-802b0c9f2635) > > There is still the possibility that the WordCloud can overflow on Desktop while resizing the window although we can adjust the props (wordPadding, desktopMinFontSize, etc.) to make it fit. > Note to be fixed in future PR: WordCloud + text at screen width 1100px is not the most visually appealing. The word cloud doesn't actually overflow, it just doesnt resize. If you refresh the page after resizing it should be fixed. I'm not sure why it doesn't fix it self when resizing :(
snedadah added 1 commit 2022-11-13 23:10:57 -05:00
continuous-integration/drone/push Build is passing Details
146f662e91
Simplified util script
snedadah merged commit e061850575 into main 2022-11-13 23:20:59 -05:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#84
No description provided.