www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add media query to section header and update sample page #85

Merged
snedadah merged 3 commits from update-smpl-page into main 2022-11-13 23:11:30 -05:00
Conversation 0 Commits 3 Files Changed 2 +32 -12
snedadah commented 2022-11-13 19:08:37 -05:00
Owner
Copy Link

https://update-smpl-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/demographics/

https://update-smpl-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/demographics/
snedadah added 2 commits 2022-11-13 19:08:38 -05:00
continuous-integration/drone/push Build is passing Details
1394a96e62 Update sample page and add media query to section header
snedadah added 1 commit 2022-11-13 19:12:22 -05:00
continuous-integration/drone/push Build is passing Details
a881f753b6 Updated samplePage margins
snedadah reviewed 2022-11-13 19:12:55 -05:00
pages/samplePage.tsx
@ -23,3 +23,3 @@
// Make vars for common configs such as common margins
const defaultBarGraphMargin = { top: 20, bottom: 40, left: 150, right: 20 };
const defaultVerticalBarGraphMargin = {
snedadah commented 2022-11-13 19:12:55 -05:00
Author
Owner
Copy Link

this is just temporary, I'm going to soon putup another pr for doing this properly using the utils file shared by everyone.

this is just temporary, I'm going to soon putup another pr for doing this properly using the utils file shared by everyone.
👍 1
snedadah requested review from e26chiu 2022-11-13 19:13:31 -05:00
e26chiu approved these changes 2022-11-13 20:28:10 -05:00
e26chiu left a comment
Contributor
Copy Link

Mostly small fixes, agree with all the changes! 🚀

Mostly small fixes, agree with all the changes! 🚀
snedadah merged commit d39a1f8274 into main 2022-11-13 23:11:30 -05:00
snedadah deleted branch update-smpl-page 2022-11-13 23:11:31 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#85
No description provided.
Delete Branch "update-smpl-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?