www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add Academics page (Closes #54) #94

Merged
e26chiu merged 14 commits from academics-page into main 2022-12-07 21:13:54 -05:00
Conversation 0 Commits 14 Files Changed 8 +2088 -24
e26chiu commented 2022-11-28 23:21:50 -05:00
Contributor
Copy Link

Summary of noteworthy changes:

  • Pie charts do NOT currently calculate percentages of values. I left it as is, and just changed the data to reflect the percentages instead of the actual value (because that is what we're displaying)
  • Minor fix to the Stacked Bar Graph so that the legend displays on top in a row instead of in a column to the right of the graph.
  • Added styling to Carousel so that it is properly centered.
  • In the Stacked Bar Graphs, I grouped certain ranges of values because the value for the individual categories would have been too small and insignificant otherwise.

Problems:

  • WordCloud still doesn't display the right text-value association no matter how much I tweak the values. The font size is correctly displayed though and all words are shown (I counted!). Errors still show in the console log.
  • WordCloud still weirdly overflows sometimes when I resize my window. See figure below. (#98)
  • Stacked Bar Graph still needs some fixing (to be done in a separate PR) related to how the legend is displayed + labels.
  • Description blurbs NEED to be re-read before copy-pasting. I just noticed that the given blurbs are sometimes incomplete, grammatically incorrect, or erroneous.
  • Bar graphs and pie charts need to have tooltips. (all graphs) (#97)
  • Tooltips in Stacked Bar Graphs are not well positioned when hovering over them. (#89)

Note in the future:

  • I just realized how redundant/boring our page may look like because we're using the same layout for each question (alternating between background, no background, left, right, center aligned). In the future, we may consider other ways to make things look more interesting.

This PR can still be merged when the WordCloud will be fixed (right text-value association).

image

Summary of noteworthy changes: - **Pie charts do NOT currently calculate percentages of values**. I left it as is, and just changed the data to reflect the percentages instead of the actual value (because that is what we're displaying) - Minor fix to the Stacked Bar Graph so that the legend displays on top in a row instead of in a column to the right of the graph. - Added styling to Carousel so that it is properly centered. - In the Stacked Bar Graphs, I grouped certain ranges of values because the value for the individual categories would have been too small and insignificant otherwise. Problems: - [x] WordCloud still doesn't display the right text-value association no matter how much I tweak the values. The font size is correctly displayed though and all words are shown (I counted!). Errors still show in the console log. - [ ] WordCloud still weirdly overflows sometimes when I resize my window. See figure below. (#98) - [ ] Stacked Bar Graph still needs some fixing (to be done in a separate PR) related to how the legend is displayed + labels. - [x] **Description blurbs NEED to be re-read before copy-pasting**. I just noticed that the given blurbs are sometimes incomplete, grammatically incorrect, or erroneous. - [ ] Bar graphs and pie charts need to have tooltips. (all graphs) (#97) - [ ] Tooltips in Stacked Bar Graphs are not well positioned when hovering over them. (#89) Note in the future: - I just realized how redundant/boring our page may look like because we're using the same layout for each question (alternating between background, no background, left, right, center aligned). In the future, we may consider other ways to make things look more interesting. This PR can still be merged when the WordCloud will be fixed (right text-value association). ![image](/attachments/a8285e3c-1ede-4028-8471-fc4bcd899397)
image.png
143 KiB
snedadah was assigned by e26chiu 2022-11-28 23:21:50 -05:00
e26chiu added 9 commits 2022-11-28 23:21:51 -05:00
continuous-integration/drone/push Build is passing Details
baf350204d Change blurbs + fix graph formatting
e26chiu requested review from snedadah 2022-11-28 23:30:58 -05:00
e26chiu added 1 commit 2022-11-30 19:16:25 -05:00
e26chiu added 2 commits 2022-12-04 19:51:33 -05:00
continuous-integration/drone/push Build is passing Details
2f18dcc738 Merge WordCloudWidth changes
snedadah added 1 commit 2022-12-05 18:28:41 -05:00
continuous-integration/drone/push Build is passing Details
b20f84267a Adjusted word cloud sizes
snedadah approved these changes 2022-12-05 18:31:42 -05:00
snedadah left a comment
Owner
Copy Link

I went ahead and adjusted the word cloud padding and font sizes for each word cloud so it no longer gives the errrors. Let me know if you notice any other issues. Rest LGTM! Though we may want to carefully read all the texts later.

I went ahead and adjusted the word cloud padding and font sizes for each word cloud so it no longer gives the errrors. Let me know if you notice any other issues. Rest LGTM! Though we may want to carefully read all the texts later.
👍 1
e26chiu added 1 commit 2022-12-05 23:20:01 -05:00
e26chiu merged commit f659393335 into main 2022-12-07 21:13:54 -05:00
e26chiu deleted branch academics-page 2022-12-07 21:13:54 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
snedadah
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#94
No description provided.
Delete Branch "academics-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?