www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add Intimacy and Drugs page (Closes #57) #103

Merged
e26chiu merged 19 commits from intimacy-drugs-page into main 2022-12-15 20:38:59 -05:00
Conversation 0 Commits 19 Files Changed 16 +725 -28
e26chiu commented 2022-12-05 23:43:12 -05:00
Contributor
Copy Link

Todo:

  • Fix Grouped bar graphs (done in a separate PR) (#104) DO NOT MERGE BEFORE OTHER GROUPED BAR PR IS DONE: #108
  • Fix responsiveness of quotation carousels.

Note that Lifestyle and Interests link in BottomNav (that appears in the co-op and Intimacy and Drugs pages) is overflowing because the text is a bit too long in mobile.

image

Other changes:

  • Add minWidth to QuotationCarousel
  • Fix friends page pie charts percentage values (one of them got converted into a bar graph because the values were too small for the pie to display itself at times and we already had many pie charts in that page already)
  • Lifestyle and Interests page had the wrong bottom nav links.
  • Fixed the lowerLabel value of bar graphs in multiple pages since the alternating labels aren't really necessary. Now that I'm doing it pretty frequently, I think it should be made a default value perhaps 🤔
  • SectionWrapper component is fixed so it's centered in mobile.
  • Fix ComponentWrapper for mobile responsive purposes
    https://intimacy-drugs-page-csc-class-profile-stagin-snedadah.k8s.csclub.cloud/intimacy-and-drugs/
Todo: - [x] Fix Grouped bar graphs (done in a separate PR) (#104) DO NOT MERGE BEFORE OTHER GROUPED BAR PR IS DONE: https://git.csclub.uwaterloo.ca/www/cs-2022-class-profile/pulls/108 - [x] Fix responsiveness of quotation carousels. Note that Lifestyle and Interests link in BottomNav (that appears in the co-op and Intimacy and Drugs pages) is overflowing because the text is a bit too long in mobile. ![image](/attachments/8bd7f7b2-96ce-4e6b-af51-fe1c3304a215) Other changes: - Add minWidth to QuotationCarousel - Fix friends page pie charts percentage values (one of them got converted into a bar graph because the values were too small for the pie to display itself at times and we already had many pie charts in that page already) - Lifestyle and Interests page had the wrong bottom nav links. - Fixed the `lowerLabel` value of bar graphs in multiple pages since the alternating labels aren't really necessary. Now that I'm doing it pretty frequently, I think it should be made a default value perhaps :thinking: - SectionWrapper component is fixed so it's centered in mobile. - Fix ComponentWrapper for mobile responsive purposes https://intimacy-drugs-page-csc-class-profile-stagin-snedadah.k8s.csclub.cloud/intimacy-and-drugs/
image.png
5.5 KiB
e26chiu added 4 commits 2022-12-05 23:43:13 -05:00
e26chiu added 5 commits 2022-12-11 21:14:26 -05:00
continuous-integration/drone/push Build is passing Details
9f8a06f03f Fix friends page pie charts
e26chiu changed title from WIP: Add Intimacy and Drugs page (Closes #57) to Add Intimacy and Drugs page (Closes #57) 2022-12-11 21:14:41 -05:00
e26chiu added 4 commits 2022-12-13 22:15:06 -05:00
continuous-integration/drone/push Build is failing Details
bd12a35a4d Fix SectionWrapper responsiveness
e26chiu added 2 commits 2022-12-13 22:26:44 -05:00
e26chiu added 1 commit 2022-12-15 08:45:25 -05:00
e26chiu added 1 commit 2022-12-15 13:51:57 -05:00
continuous-integration/drone/push Build is passing Details
0ecad4af16 Fix lint
snedadah reviewed 2022-12-15 14:41:43 -05:00
snedadah left a comment
Owner
Copy Link

Looking really good!!

I think some of the changes to the component wrapper broke the centering on the sample page.

image
Is that expected? If its a quick fix then could you please fix it so we have a good sample page (feel free to change the page however you want). If its not (>5 min effort), just delete the sample page (since I don't think we should have a broken sample page)

Also, I think we should add white-space: break-spaces; to the seaction header, so the "drugs" isnt cut off mid word on mobile.

image

Looking really good!! I think some of the changes to the component wrapper broke the centering on the sample page. ![image](/attachments/a86bf041-fea3-4925-97b6-b2fe51942814) Is that expected? If its a quick fix then could you please fix it so we have a good sample page (feel free to change the page however you want). If its not (>5 min effort), just delete the sample page (since I don't think we should have a broken sample page) Also, I think we should add `white-space: break-spaces;` to the seaction header, so the "drugs" isnt cut off mid word on mobile. ![image](/attachments/a4b6e0f4-1f52-44b0-a9d8-e341e8dfcadb)
image.png
50 KiB
image.png
50 KiB
image.png
e26chiu added 2 commits 2022-12-15 19:20:04 -05:00
continuous-integration/drone/push Build is passing Details
a50d92a93e Fix word-break in sectionHeader
snedadah approved these changes 2022-12-15 19:41:17 -05:00
snedadah left a comment
Owner
Copy Link

nice work! this page is very interesting :)

nice work! this page is very interesting :)
e26chiu merged commit d77ebe0f8d into main 2022-12-15 20:38:59 -05:00
e26chiu deleted branch intimacy-drugs-page 2022-12-15 20:38:59 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#103
No description provided.
Delete Branch "intimacy-drugs-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?