Fix Line Graph Legend Position (Close #100) #107

Merged
b72zhou merged 5 commits from b72zhou-line-graph-legend into main 3 months ago
Collaborator
There is no content yet.
b72zhou added 1 commit 4 months ago
72ad473050 :fix: legend
b72zhou added 1 commit 4 months ago
cccfac319e Merge branch 'main' into b72zhou-line-graph-legend
b72zhou changed title from Fix Line Graph Legend Position to Fix Line Graph Legend Position (Close #100) 4 months ago
b72zhou requested review from e26chiu 4 months ago
e26chiu added 1 commit 4 months ago
2e5ffabf08 Get rid of unused vars + center legend
e26chiu approved these changes 4 months ago
e26chiu left a comment
Collaborator

I got rid of other unused variables/props in the component. I also modified the LineGraph legend so that it is only displayed centered at a fixed space from the graph because I found it more simple than having a left and top offset of the graph and legend. Let me know if that is good with you @b72zhou Otherwise, LGTM! 🚀

I got rid of other unused variables/props in the component. I also modified the LineGraph legend so that it is only displayed centered at a fixed space from the graph because I found it more simple than having a left and top offset of the graph and legend. Let me know if that is good with you @b72zhou Otherwise, LGTM! 🚀
e26chiu approved these changes 4 months ago
e26chiu left a comment
Collaborator

I just noticed a small thing.

I just noticed a small thing.
flexDirection: legendPosition === "right" ? "row" : "column-reverse",
}}
>
<div className={styles.container}>
Collaborator

What is styles.container for? Where is the container class?

What is `styles.container` for? Where is the `container` class?
Poster
Collaborator

sry a class was there but deleted, got rid of it

sry a class was there but deleted, got rid of it
b72zhou added 1 commit 3 months ago
e1eb3c24f8 :chore: minor fix
b72zhou added 1 commit 3 months ago
e0c9ce77eb Merge branch 'main' into b72zhou-line-graph-legend
b72zhou merged commit 2720728e46 into main 3 months ago
b72zhou deleted branch b72zhou-line-graph-legend 3 months ago

Reviewers

e26chiu approved these changes 4 months ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 2720728e46.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#107
Loading…
There is no content yet.