Fix Line Graph Legend Position (Close #100)
Mergedb72zhou merged 5 commits from
main3 months ago
Reference in new issue
There is no content yet.
Delete Branch 'b72zhou-line-graph-legend'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Fix Line Graph Legend Positionto Fix Line Graph Legend Position (Close #100) 4 months ago
I got rid of other unused variables/props in the component. I also modified the LineGraph legend so that it is only displayed centered at a fixed space from the graph because I found it more simple than having a left and top offset of the graph and legend. Let me know if that is good with you @b72zhou Otherwise, LGTM! 🚀
I just noticed a small thing.
flexDirection: legendPosition === "right" ? "row" : "column-reverse",
styles.containerfor? Where is the
sry a class was there but deleted, got rid of it
2720728e46into main 3 months ago