Add global colours and styles (Closes #11)
Mergede26chiu merged 2 commits from
main12 months ago
Reference in new issue
There is no content yet.
Delete Branch 'global-colours-and-styles'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Note: Using custom properties for variables (CSS as a single source of truth)
Looks good to me, few comments/questions:
should this be:
--label: var(--dark--label);? (extra dash between the label to match above)
Indeed, it should be
--dark--label! Good catch! :D
Should we consider adding a bit of global padding here as well? (edit: sorry just read, you mentioned this in your pr comment)
We would have to agree on a common margin for the entire document. I see that in the class profile of software engineering 2021, the margins are set to
auto. I'd say we can go with that so we can resize the content however we want.
In this day and age, we only need
woffas fallback) to support the vast majority of modern browsers. Stackoverflow reference
(These are the only two formats we have on the website, btw.)
Let's get rid of the
Also, we used this tool to generate the font-face declarations for the website, if you want to give it a try: https://google-webfonts-helper.herokuapp.com/fonts (or you can use whatever tool you used here)
NIT: can we rename this colour to
dark-blue? Then we can name the colours
NIT: can we put an empty line between the light and dark variables? 😅
NIT: can we put an empty line between the dark colour variables and the no-colour-prefix variables?
NIT: can we have an empty line between the CSS variables and the actual styles? 😁
a258wang referenced this pull request 12 months ago
e5acb92e3einto main 12 months ago