Fixing the link issue on contributors page. Now the redirection occurs only when link exists. #150
Closed
r2shuai
wants to merge 4 commits from richard-shuai/contribution-link into main
snedadah
e26chiu
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'richard-shuai/contribution-link'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Fixing the link issue on contributors page. Now the redirection occurs only when link exists.to WIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2 months agoWIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists.to Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2 months agoIssue #144
Fixing the link issue on contributors page. Now the redirection occurs only when link exists.to WIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2 months agoWIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists.to Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2 months agoNice Work!!
Btw, you should put the "Closes #144" in the PR description, and git tea will auto close the issue.
Furthremore, for something like "Now the redirection occurs only when link exists." I reccomend you put that in the PR description.
LGTM! @r2shuai I tested this locally and it works well! You can merge this! Thank you for working on a class profile issue this early!
Note for the title of the PR, a small nitpick, I would just put a short concise version of the title of the PR (e.g. Fix link issue in contributors page), the remaining text and detail can go in the description ("Now the redirection occurs only...") This is just a small nitpick though!
Reviewers