www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Fixing the link issue on contributors page. Now the redirection occurs only when link exists. #150

Closed
r2shuai wants to merge 4 commits from richard-shuai/contribution-link into main
pull from: richard-shuai/contribution-link
merge into: www:main
Conversation 1 Commits 4 Files Changed -
r2shuai commented 2023-01-25 21:54:30 -05:00
Member
Copy Link
No description provided.
r2shuai added 1 commit 2023-01-25 21:54:32 -05:00
r2shuai changed title from Fixing the link issue on contributors page. Now the redirection occurs only when link exists. to WIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2023-01-25 21:54:43 -05:00
r2shuai requested review from snedadah 2023-01-25 21:54:58 -05:00
r2shuai requested review from e26chiu 2023-01-25 21:54:58 -05:00
r2shuai changed title from WIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists. to Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2023-01-25 21:56:32 -05:00
r2shuai commented 2023-01-25 21:59:11 -05:00
Author
Member
Copy Link

Issue #144

Issue #144
r2shuai changed title from Fixing the link issue on contributors page. Now the redirection occurs only when link exists. to WIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2023-01-25 22:06:54 -05:00
r2shuai added 1 commit 2023-01-25 22:12:17 -05:00
continuous-integration/drone/push Build is passing Details
cc67c9bd5c Preventing default for anchor tag
r2shuai changed title from WIP: Fixing the link issue on contributors page. Now the redirection occurs only when link exists. to Fixing the link issue on contributors page. Now the redirection occurs only when link exists. 2023-01-25 22:14:15 -05:00
snedadah approved these changes 2023-01-25 23:20:48 -05:00
snedadah left a comment
Owner
Copy Link

Nice Work!!

Btw, you should put the "Closes #144" in the PR description, and git tea will auto close the issue.

Furthremore, for something like "Now the redirection occurs only when link exists." I reccomend you put that in the PR description.

Nice Work!! Btw, you should put the "Closes #144" in the PR description, and git tea will auto close the issue. Furthremore, for something like "Now the redirection occurs only when link exists." I reccomend you put that in the PR description.
👍 1
e26chiu approved these changes 2023-01-26 21:18:14 -05:00
e26chiu left a comment
Contributor
Copy Link

LGTM! @r2shuai I tested this locally and it works well! You can merge this! Thank you for working on a class profile issue this early!

Note for the title of the PR, a small nitpick, I would just put a short concise version of the title of the PR (e.g. Fix link issue in contributors page), the remaining text and detail can go in the description ("Now the redirection occurs only...") This is just a small nitpick though!

LGTM! @r2shuai I tested this locally and it works well! You can merge this! Thank you for working on a class profile issue this early! Note for the title of the PR, a small nitpick, I would just put a short concise version of the title of the PR (e.g. Fix link issue in contributors page), the remaining text and detail can go in the description ("Now the redirection occurs only...") This is just a small nitpick though!
r2shuai added 1 commit 2023-01-29 17:59:24 -05:00
continuous-integration/drone/push Build is passing Details
6be9f031b0 Merge branch 'main' into richard-shuai/contribution-link
r2shuai scheduled this pull request to auto merge when all checks succeed 2023-01-29 18:00:30 -05:00
r2shuai added 1 commit 2023-02-01 21:48:38 -05:00
continuous-integration/drone/push Build is passing Details
8afa78834d Merge branch 'main' into richard-shuai/contribution-link
snedadah closed this pull request 2023-02-04 01:49:12 -05:00
All checks were successful
continuous-integration/drone/push Build is passing
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#150
No description provided.
Delete Branch "richard-shuai/contribution-link"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?