www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

View button font change #152

Merged
r2shuai merged 5 commits from view-font into main 2023-02-01 21:45:47 -05:00
Conversation 0 Commits 5 Files Changed 1 +1
r2shuai commented 2023-01-26 15:45:32 -05:00
Member
Copy Link

Closes #145

Changes the font of view on the front page so it syncs with the rest of the page.

https://view-font-csc-class-profile-staging-snedadah.k8s.csclub.cloud/

Closes #145 Changes the font of view on the front page so it syncs with the rest of the page. https://view-font-csc-class-profile-staging-snedadah.k8s.csclub.cloud/
r2shuai added 4 commits 2023-01-26 15:45:34 -05:00
continuous-integration/drone/push Build is passing Details
cc67c9bd5c Preventing default for anchor tag
continuous-integration/drone/push Build is passing Details
9e51b39729 View font sync
r2shuai requested review from snedadah 2023-01-26 15:45:47 -05:00
r2shuai requested review from e26chiu 2023-01-26 15:45:47 -05:00
e26chiu approved these changes 2023-01-26 21:27:59 -05:00
e26chiu left a comment
Contributor
Copy Link

LGTM! @r2shuai

LGTM! @r2shuai
pages/frontpage.module.css
@ -86,6 +86,7 @@
font-size: calc(30rem / 16);
color: var(--primary-accent-light);
font-weight: 700;
font-family: 'Inconsolata';
e26chiu commented 2023-01-26 21:27:31 -05:00
Contributor
Copy Link

Small suggestion (optional): if you've looked at other parts of the code that specify the font family, we have monospace as the fallback font family. You can add that! Not a blocker for this PR though!

Small suggestion (optional): if you've looked at other parts of the code that specify the font family, we have `monospace` as the fallback font family. You can add that! Not a blocker for this PR though!
👍 1
snedadah approved these changes 2023-01-31 00:45:28 -05:00
r2shuai added 1 commit 2023-02-01 20:10:00 -05:00
continuous-integration/drone/push Build is passing Details
1f685d049c Merge branch 'main' into view-font
r2shuai merged commit 8f39bb3483 into main 2023-02-01 21:45:47 -05:00
r2shuai deleted branch view-font 2023-02-01 21:45:48 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#152
No description provided.
Delete Branch "view-font"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?