View button font change #152

Merged

r2shuai merged 5 commits from view-font into main 2 months ago

r2shuai commented 2 months ago

Collaborator

Closes #145

Changes the font of view on the front page so it syncs with the rest of the page.

https://view-font-csc-class-profile-staging-snedadah.k8s.csclub.cloud/

r2shuai added 4 commits 2 months ago

2c966d130d Fixing the link issue on contributors page. The redirection occurs only when link exists

cc67c9bd5c Preventing default for anchor tag

81175cb383 Merged the no religious affliation option with the atheist option

9e51b39729 View font sync

r2shuai requested review from snedadah 2 months ago

r2shuai requested review from e26chiu 2 months ago

e26chiu approved these changes 2 months ago

e26chiu left a comment

Collaborator

pages/frontpage.module.css

													
					  font-size: calc(30rem / 16);
				
					  color: var(--primary-accent-light);
				
					  font-weight: 700;
				
					  font-family: 'Inconsolata';

e26chiu commented 2 months ago

Collaborator

Small suggestion (optional): if you've looked at other parts of the code that specify the font family, we have monospace as the fallback font family. You can add that! Not a blocker for this PR though!

👍 1

snedadah approved these changes 2 months ago

r2shuai added 1 commit 2 months ago

1f685d049c Merge branch 'main' into view-font

r2shuai merged commit 8f39bb3483 into main 2 months ago

r2shuai deleted branch view-font 2 months ago

r2shuai referenced this issue from a commit 2 months ago

View button font change (#152)

Reviewers

e26chiu approved these changes 2 months ago

snedadah approved these changes 2 months ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 8f39bb3483.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#152