www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Fixed incorrect data #153

Merged
snedadah merged 2 commits from fix-data into main 2023-01-31 00:36:29 -05:00
Conversation 0 Commits 2 Files Changed 4 +65 -27
snedadah commented 2023-01-26 22:22:32 -05:00
Owner
Copy Link
No description provided.
snedadah added 1 commit 2023-01-26 22:22:33 -05:00
continuous-integration/drone/push Build is passing Details
93d0a69d78 Fixed incorrect data
snedadah requested review from e26chiu 2023-01-26 23:42:59 -05:00
e26chiu added 1 commit 2023-01-28 11:27:30 -05:00
continuous-integration/drone/push Build is passing Details
fbb1bb4bd9 Correct data
e26chiu approved these changes 2023-01-28 11:29:16 -05:00
e26chiu left a comment
Contributor
Copy Link

Looks like every point in the document was addressed, good job @snedadah ! I changed some of the data points according to the google sheets (inconsistencies, etc.) Everything should be ready to merge

Looks like every point in the document was addressed, good job @snedadah ! I changed some of the data points according to the google sheets (inconsistencies, etc.) Everything should be ready to merge
data/post-grad.ts Outdated
@ -228,4 +228,12 @@ export const P8 = [
text: "Computer Networking",
value: 2,
},
{
e26chiu commented 2023-01-28 11:25:04 -05:00
Contributor
Copy Link

I also noticed in the original data, there is a generic Computer Software category which most people opted (65). I didn't include this category in my change because it wasn't telling us anything new. Do we want to still include this category?

I also noticed in the original data, there is a generic Computer Software category which most people opted (65). I didn't include this category in my change because it wasn't telling us anything new. Do we want to still include this category?
snedadah commented 2023-01-31 00:36:23 -05:00
Author
Owner
Copy Link

No I don't think we should

No I don't think we should
snedadah merged commit 09978edd0e into main 2023-01-31 00:36:29 -05:00
snedadah deleted branch fix-data 2023-01-31 00:36:29 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#153
No description provided.
Delete Branch "fix-data"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?