www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Fixed word cloud data issues #159

Merged
snedadah merged 4 commits from shahanneda/fix-word-cloud-issues into main 2023-02-05 13:40:09 -05:00
Conversation 0 Commits 4 Files Changed 4 +11 -19
snedadah commented 2023-01-31 00:51:07 -05:00
Owner
Copy Link
No description provided.
snedadah added 1 commit 2023-01-31 00:51:08 -05:00
continuous-integration/drone/push Build is passing Details
7895765250 Fix word cloud data issues
snedadah requested review from e26chiu 2023-01-31 00:51:17 -05:00
snedadah reviewed 2023-01-31 00:52:18 -05:00
pages/lifestyle-and-interests.tsx
@ -169,3 +169,3 @@
<ComponentWrapper
heading="What is your favourite restaurant to go to on/around campus?"
bodyText="With all the diverse restaurant around campus, it seems like the most popular choices of food are sushi, noodles, and shawarma (Lazeez hehehe)."
bodyText="With all the diverse restaurant around campus, it seems like the most popular choices of food are sushi, noodles, and shawarma."
snedadah commented 2023-01-31 00:52:18 -05:00
Author
Owner
Copy Link

oops, idk why i did this. will be override later anyway when we copy all the text.

oops, idk why i did this. will be override later anyway when we copy all the text.
😆 1
snedadah added 1 commit 2023-01-31 00:53:33 -05:00
snedadah added 1 commit 2023-01-31 00:54:05 -05:00
continuous-integration/drone/push Build is passing Details
6ab6b47843 Fixed data
e26chiu added 1 commit 2023-02-04 13:20:56 -05:00
continuous-integration/drone/push Build is passing Details
301a1f76f0 Fix grammar mistake
e26chiu approved these changes 2023-02-04 13:22:19 -05:00
e26chiu left a comment
Contributor
Copy Link

LGTM! I have a few non-blocking questions about miscellaneous data.

LGTM! I have a few non-blocking questions about miscellaneous data.
data/miscellaneous.ts
@ -218,7 +218,7 @@ export const M7 = [
value: 3,
e26chiu commented 2023-02-04 13:15:56 -05:00
Contributor
Copy Link

Some of these categories are repeat of each other. E.g. Communication, Become more social, (to a lesser extent) Improved relationship
E.g. Responsability, Grown as a person, Mature, Life skills

Some of these categories are repeat of each other. E.g. Communication, Become more social, (to a lesser extent) Improved relationship E.g. Responsability, Grown as a person, Mature, Life skills
snedadah commented 2023-02-05 13:37:31 -05:00
Author
Owner
Copy Link

I don't think we should manually put these together? I feel like that would be too much interfering, its interesting to see different thoughts on the same thing imo.

I don't think we should manually put these together? I feel like that would be too much interfering, its interesting to see different thoughts on the same thing imo.
data/miscellaneous.ts Outdated
@ -319,3 +319,3 @@
},
{
text: "Mindfullness & Mature",
text: "Mindfulness & Mature",
e26chiu commented 2023-02-04 13:13:28 -05:00
Contributor
Copy Link

Mindfulness & Mature sounds weird, I don't know if it's just me... I prefer keeping mindfulness only.

Mindfulness & Mature sounds weird, I don't know if it's just me... I prefer keeping mindfulness only.
snedadah commented 2023-02-05 13:38:21 -05:00
Author
Owner
Copy Link

can't seem to find it anymore?

can't seem to find it anymore?
data/miscellaneous.ts
@ -323,3 +323,3 @@
},
{
text: "Self regulation",
text: "Self-regulation",
e26chiu commented 2023-02-04 13:21:39 -05:00
Contributor
Copy Link

Is "Have sex" comment SFW?

Is "Have sex" comment SFW?
snedadah commented 2023-02-05 13:38:11 -05:00
Author
Owner
Copy Link

I think its fine.

I think its fine.
snedadah merged commit 8c0b5f8556 into main 2023-02-05 13:40:09 -05:00
snedadah deleted branch shahanneda/fix-word-cloud-issues 2023-02-05 13:40:10 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#159
No description provided.
Delete Branch "shahanneda/fix-word-cloud-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?