Bar Graph Component
Mergeda258wang merged 16 commits from
main8 months ago
Reference in new issue
There is no content yet.
Delete Branch 'a258wang-bar-graph'
Deleting a branch is permanent. It CANNOT be undone. Continue?
<BarGraphHorizontal />component and a
Possible changes for the future:
da3c9f92bb9 months ago
293183064a9 months ago
WIP: Bar Graph Componentto Bar Graph Component 9 months ago
Looks good to me! And yeah we definitely should add the title (though maybe we should instead have some sort of wrapper title component for all the graphs)
Do we need to specify the font family on all of these even though the font is set globally for the page?
Also small nit: If we do need to set the font, should we add the monospace fallback here?
I just tried it, and it looks like the visx Text component automatically uses Arial if you don't specify a font, so we either have to pass the font family as a prop to the Text component, or we have to specify the font on each class as done here.
Good catch on adding the monospace fallback though.
I'm going to merge this without the graph title for now, and we can always come back later to add it if we want - in the meantime, throwing a heading above the graph would work in a pinch lol
6735c52914into main 8 months ago