www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests Projects Releases Wiki Activity
Labels Milestones

Changed academic average bar graph colors #160

Merged
dlslo merged 2 commits from darren/change-graph-colors into main 2 months ago
Conversation 1 Commits 2 Files Changed 3
dlslo commented 2 months ago
Collaborator

Closes #146

https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/

Closes #146 https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/
dlslo added 1 commit 2 months ago
continuous-integration/drone/push Build is passing
Details
b383a38f4d Changed academic average bar graph colors
dlslo requested review from snedadah 2 months ago
dlslo requested review from e26chiu 2 months ago
snedadah approved these changes 2 months ago
Dismissed
snedadah left a comment
Owner

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2 months ago
snedadah left a comment
Owner

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2 months ago
snedadah left a comment
Owner

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2 months ago
snedadah left a comment
Owner

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2 months ago
snedadah left a comment
Owner

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2 months ago
snedadah left a comment
Owner

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
snedadah reviewed 2 months ago
snedadah left a comment
Owner

Its looking a bit strange for me on staging for some reason

image

Its looking a bit strange for me on staging for some reason ![image](/attachments/ebd8bb15-3c8f-4532-84c8-90a78d304ae7)
image.png
16 KiB
snedadah dismissed snedadah’s review 2 months ago
Reason:

accidental approval

snedadah commented 2 months ago
Owner

Sorry for the spam, gittea bugs...
For somerason it looks like the colros areant showing up on staging (https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/) I can help you debug more later if needed.

Sorry for the spam, gittea bugs... For somerason it looks like the colros areant showing up on staging (https://darren-change-graph-colors-csc-class-profile-snedadah.k8s.csclub.cloud/) I can help you debug more later if needed.
image.png
16 KiB
e26chiu requested changes 2 months ago
e26chiu left a comment
Collaborator

I noticed the same problem as @snedadah . You can check my comments below for hints. Otherwise, LGTM!

I noticed the same problem as @snedadah . You can check my comments below for hints. Otherwise, LGTM!
pages/_app.css
--dark--primary-accent-light: var(--light-pink);
--dark--primary-accent-lighter: var(--lighter-pink);
--dark--primary-accent-dark: #dc538e;
--dark--primary-accent-darker: #c8417c;
e26chiu commented 2 months ago
Collaborator

Make sure you define the default value for primary-accent-dark and primary-accent-darker in body so that these colours can be properly displayed.

Make sure you define the default value for `primary-accent-dark` and `primary-accent-darker` in body so that these colours can be properly displayed.
pages/_app.css
--primary-accent-darker: var(--dark--primary-accent-darker);
--secondary-accent: var(--dark--secondary-accent);
--secondary-accent-light: var(--dark--secondary-accent-light);
--secondary-accent-dark: var(--primary-accent-dark);
e26chiu commented 2 months ago
Collaborator

This line was leftover code that I noticed isn't being used anywhere else. You can delete it in this PR. Thanks!

This line was leftover code that I noticed isn't being used anywhere else. You can delete it in this PR. Thanks!
dlslo added 1 commit 2 months ago
continuous-integration/drone/push Build is passing
Details
ca606a015d Fixed default colors
snedadah approved these changes 2 months ago
snedadah left a comment
Owner

Nice work! Seems to be fixed now!

Nice work! Seems to be fixed now!
dlslo merged commit 71f9125bf2 into main 2 months ago
dlslo deleted branch darren/change-graph-colors 2 months ago

Reviewers

e26chiu requested changes 2 months ago
snedadah approved these changes 2 months ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 71f9125bf2.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
e26chiu
snedadah
Labels
Apply labels
Clear labels
Bug Component Config Good First Issue Low-Priority Page
No Label Bug Component Config Good First Issue Low-Priority Page
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#160
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'darren/change-graph-colors'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes