Fix Staging server 404 error #22

Merged
snedadah merged 4 commits from shahanneda/fix-404-page into main 3 months ago
Collaborator

Previously when clicking a link such as https://main-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground it would give a 404 error since those links do not have the .html appended to them, this pr adds an nginx config to address this issue.

https://shahanneda-fix-404-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground

Previously when clicking a link such as https://main-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground it would give a 404 error since those links do not have the `.html` appended to them, this pr adds an nginx config to address this issue. https://shahanneda-fix-404-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground
snedadah added 3 commits 3 months ago
a940a7eb51
Test staging nginx config
5ba6bc848a
fixed typo
b79168b2c6
Fixed issue with non html path
snedadah requested review from a3thakra 3 months ago
snedadah requested review from a258wang 3 months ago
snedadah requested review from n3parikh 3 months ago
a258wang approved these changes 3 months ago
a258wang left a comment
Owner

I'm not 100% sure what's happening here, but it seems to be working, so let's merge it and fix it later if things are broken. 😆

I'm not 100% sure what's happening here, but it seems to be working, so let's merge it and fix it later if things are broken. 😆
Owner

https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7

if you can add this in this repos next config then that should fox the error

https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7 if you can add this in this repos next config then that should fox the error
snedadah added 1 commit 3 months ago
28d3b2cc65
Added trailing slashes to next config
Poster
Collaborator

https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7

if you can add this in this repos next config then that should fox the error

Good catch, thanks for this! It still doesnt fully solve the problem since the ngix server needs the ".html" appened to it if we dont give it a config, so we still need to have the ngix config.

> https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7 > > if you can add this in this repos next config then that should fox the error Good catch, thanks for this! It still doesnt fully solve the problem since the ngix server needs the ".html" appened to it if we dont give it a config, so we still need to have the ngix config.
snedadah merged commit 854c5d5bae into main 3 months ago
snedadah deleted branch shahanneda/fix-404-page 3 months ago

Reviewers

a3thakra was requested for review 3 months ago
n3parikh was requested for review 3 months ago
a258wang approved these changes 3 months ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 854c5d5bae.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#22
Loading…
There is no content yet.