Fix Staging server 404 error #22

Merged

snedadah merged 4 commits from shahanneda/fix-404-page into main 2022-07-07 19:52:44 -04:00

Conversation 2 Commits 4 Files Changed 3

snedadah commented 2022-07-01 16:20:36 -04:00

repo.issues.owner

Previously when clicking a link such as https://main-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground it would give a 404 error since those links do not have the .html appended to them, this pr adds an nginx config to address this issue.

https://shahanneda-fix-404-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground

Previously when clicking a link such as https://main-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground it would give a 404 error since those links do not have the `.html` appended to them, this pr adds an nginx config to address this issue. https://shahanneda-fix-404-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/playground

snedadah added 3 commits 2022-07-01 16:20:37 -04:00

a940a7eb51

Test staging nginx config

5ba6bc848a

fixed typo

b79168b2c6

Fixed issue with non html path

snedadah requested review from a3thakra 2022-07-01 16:20:52 -04:00

snedadah requested review from a258wang 2022-07-01 16:20:53 -04:00

snedadah requested review from n3parikh 2022-07-01 16:21:02 -04:00

a258wang approved these changes 2022-07-04 20:26:14 -04:00

a258wang left a comment

repo.issues.owner

I'm not 100% sure what's happening here, but it seems to be working, so let's merge it and fix it later if things are broken. 😆

I'm not 100% sure what's happening here, but it seems to be working, so let's merge it and fix it later if things are broken. 😆

a3thakra commented 2022-07-05 04:44:19 -04:00

repo.issues.owner

https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7

if you can add this in this repos next config then that should fox the error

https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7 if you can add this in this repos next config then that should fox the error

snedadah added 1 commit 2022-07-07 19:48:43 -04:00

28d3b2cc65

Added trailing slashes to next config

snedadah commented 2022-07-07 19:49:34 -04:00

repo.issues.poster

repo.issues.owner

https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7

if you can add this in this repos next config then that should fox the error

Good catch, thanks for this! It still doesnt fully solve the problem since the ngix server needs the ".html" appened to it if we dont give it a config, so we still need to have the ngix config.

> https://git.csclub.uwaterloo.ca/www/www-new/src/branch/main/next.config.js#L7 > > if you can add this in this repos next config then that should fox the error Good catch, thanks for this! It still doesnt fully solve the problem since the ngix server needs the ".html" appened to it if we dont give it a config, so we still need to have the ngix config.

snedadah merged commit 854c5d5bae into main 2022-07-07 19:52:44 -04:00

snedadah deleted branch shahanneda/fix-404-page 2022-07-07 19:52:44 -04:00

snedadah referenced this issue from a commit 2022-07-07 19:52:44 -04:00

Fix Staging server 404 error (#22)

snedadah referenced this issue from a commit 2022-07-21 01:51:43 -04:00

Fix Staging server 404 error (#22)

Sign in to join this conversation.

Reviewers

No reviewers

a3thakra

n3parikh

a258wang

Labels

Clear labels   

Bug

  

Component

  

Config

  

Good First Issue

  

Low-Priority

  

Page

No Label

Bug

Component

Config

Good First Issue

Low-Priority

Page

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#22

No description provided.