Add Textbox Component #45

Merged
j285he merged 3 commits from j285he-textbox-component into main 5 months ago
Collaborator
Closes #39. Padding will look correct when !46 is merged in. https://j285he-textbox-component-csc-class-profile-staging-snedadah.k8s.csclub.cloud
j285he added 2 commits 5 months ago
3715e3138b Add Textbox
573acc858e Center
j285he requested review from a258wang 5 months ago
j285he requested review from snedadah 5 months ago
j285he requested review from e26chiu 5 months ago
j285he requested review from b72zhou 5 months ago
a258wang approved these changes 5 months ago
a258wang left a comment
Owner

Looks pretty good! I'm expecting that whoever works on the front page can tweak the exact numbers etc. as needed.

Maybe consider renaming to CenterTextWrapper or even just CenterWrapper or something, for a bit more consistency with the ComponentWrapper component we have? Or maybe call it CenterTextbox? Idk, I just think that Textbox is a very generic name, so we could probably give this component a slightly more specific name. 😂

Looks pretty good! I'm expecting that whoever works on the front page can tweak the exact numbers etc. as needed. Maybe consider renaming to `CenterTextWrapper` or even just `CenterWrapper` or something, for a bit more consistency with the `ComponentWrapper` component we have? Or maybe call it `CenterTextbox`? Idk, I just think that `Textbox` is a very generic name, so we could probably give this component a slightly more specific name. 😂
j285he added 1 commit 5 months ago
792407bce1 Code review fixes
snedadah approved these changes 5 months ago
snedadah left a comment
Owner

LGTM as well!

LGTM as well!
j285he merged commit e2d19a281a into main 5 months ago
j285he deleted branch j285he-textbox-component 5 months ago
j285he referenced this issue from a commit 5 months ago

Reviewers

e26chiu was requested for review 5 months ago
b72zhou was requested for review 5 months ago
a258wang approved these changes 5 months ago
snedadah approved these changes 5 months ago
continuous-integration/drone/push Build is passing
The pull request has been merged as e2d19a281a.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#45
Loading…
There is no content yet.