www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 21 Pull Requests Projects Releases Wiki Activity
Labels Milestones

Add Textbox Component #45

Merged
j285he merged 3 commits from j285he-textbox-component into main 5 months ago
Conversation 0 Commits 3 Files Changed 3
j285he commented 5 months ago
Collaborator

Closes #39.

Padding will look correct when !46 is merged in.

https://j285he-textbox-component-csc-class-profile-staging-snedadah.k8s.csclub.cloud

Closes #39. Padding will look correct when !46 is merged in. https://j285he-textbox-component-csc-class-profile-staging-snedadah.k8s.csclub.cloud
j285he added 2 commits 5 months ago
continuous-integration/drone/push Build is passing
Details
3715e3138b Add Textbox
continuous-integration/drone/push Build is passing
Details
573acc858e Center
j285he requested review from a258wang 5 months ago
j285he requested review from snedadah 5 months ago
j285he requested review from e26chiu 5 months ago
j285he requested review from b72zhou 5 months ago
a258wang approved these changes 5 months ago
a258wang left a comment
Owner

Looks pretty good! I'm expecting that whoever works on the front page can tweak the exact numbers etc. as needed.

Maybe consider renaming to CenterTextWrapper or even just CenterWrapper or something, for a bit more consistency with the ComponentWrapper component we have? Or maybe call it CenterTextbox? Idk, I just think that Textbox is a very generic name, so we could probably give this component a slightly more specific name. 😂

Looks pretty good! I'm expecting that whoever works on the front page can tweak the exact numbers etc. as needed. Maybe consider renaming to `CenterTextWrapper` or even just `CenterWrapper` or something, for a bit more consistency with the `ComponentWrapper` component we have? Or maybe call it `CenterTextbox`? Idk, I just think that `Textbox` is a very generic name, so we could probably give this component a slightly more specific name. 😂
j285he added 1 commit 5 months ago
continuous-integration/drone/push Build is passing
Details
792407bce1 Code review fixes
snedadah approved these changes 5 months ago
snedadah left a comment
Owner

LGTM as well!

LGTM as well!
j285he merged commit e2d19a281a into main 5 months ago
j285he deleted branch j285he-textbox-component 5 months ago
j285he referenced this issue from a commit 5 months ago
Add Textbox Component (#45)

Reviewers

e26chiu was requested for review 5 months ago
b72zhou was requested for review 5 months ago
a258wang approved these changes 5 months ago
snedadah approved these changes 5 months ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as e2d19a281a.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
e26chiu
b72zhou
a258wang
snedadah
Labels
Apply labels
Clear labels
Bug Component Config Good First Issue Low-Priority Page
No Label Bug Component Config Good First Issue Low-Priority Page
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#45
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'j285he-textbox-component'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes