www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add Textbox Component #45

Merged
j285he merged 3 commits from j285he-textbox-component into main 2022-09-09 17:01:36 -04:00
Conversation 0 Commits 3 Files Changed 3 +50
j285he commented 2022-08-31 23:08:28 -04:00
Member
Copy Link

Closes #39.

Padding will look correct when !46 is merged in.

https://j285he-textbox-component-csc-class-profile-staging-snedadah.k8s.csclub.cloud

Closes #39. Padding will look correct when !46 is merged in. https://j285he-textbox-component-csc-class-profile-staging-snedadah.k8s.csclub.cloud
j285he added 2 commits 2022-08-31 23:08:29 -04:00
continuous-integration/drone/push Build is passing Details
3715e3138b Add Textbox
continuous-integration/drone/push Build is passing Details
573acc858e Center
j285he requested review from a258wang 2022-08-31 23:23:52 -04:00
j285he requested review from snedadah 2022-08-31 23:23:55 -04:00
j285he requested review from e26chiu 2022-08-31 23:23:59 -04:00
j285he requested review from b72zhou 2022-08-31 23:24:03 -04:00
a258wang approved these changes 2022-09-03 00:51:51 -04:00
a258wang left a comment
Owner
Copy Link

Looks pretty good! I'm expecting that whoever works on the front page can tweak the exact numbers etc. as needed.

Maybe consider renaming to CenterTextWrapper or even just CenterWrapper or something, for a bit more consistency with the ComponentWrapper component we have? Or maybe call it CenterTextbox? Idk, I just think that Textbox is a very generic name, so we could probably give this component a slightly more specific name. 😂

Looks pretty good! I'm expecting that whoever works on the front page can tweak the exact numbers etc. as needed. Maybe consider renaming to `CenterTextWrapper` or even just `CenterWrapper` or something, for a bit more consistency with the `ComponentWrapper` component we have? Or maybe call it `CenterTextbox`? Idk, I just think that `Textbox` is a very generic name, so we could probably give this component a slightly more specific name. 😂
j285he added 1 commit 2022-09-07 23:20:19 -04:00
continuous-integration/drone/push Build is passing Details
792407bce1 Code review fixes
snedadah approved these changes 2022-09-09 11:15:36 -04:00
snedadah left a comment
Owner
Copy Link

LGTM as well!

LGTM as well!
j285he merged commit e2d19a281a into main 2022-09-09 17:01:36 -04:00
j285he deleted branch j285he-textbox-component 2022-09-09 17:01:36 -04:00
j285he referenced this issue from a commit 2022-09-09 17:01:36 -04:00
Add Textbox Component (#45)
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
b72zhou
a258wang
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#45
No description provided.
Delete Branch "j285he-textbox-component"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?