Is there any reason why we aren't doing width: 100% (or maybe it's not even necessary to specify the width) and then just letting padding/margin handle the spacing?
Is there any reason why we aren't doing `width: 100%` (or maybe it's not even necessary to specify the width) and then just letting padding/margin handle the spacing?
Is the background-color necessary here? I would have thought that it'd just be transparent by default, which would be fine since the page background colour is what we want.
Is the `background-color` necessary here? I would have thought that it'd just be transparent by default, which would be fine since the page background colour is what we want.
I know this is a Figma thing and not an us thing, but why is the text here not just the usual white? 🥴 (Is it because the angle brackets are white? Why are the angle brackets white and not one of the usual accent colours?)
It's your choice, do whatever you think looks best. (Personally, I wonder what pink aside text + white main text would look like?)
Though I do want to ask if we really need a --secondary-text variable, or if using --primary-accent-lighter is sufficient?
I know this is a Figma thing and not an us thing, but *why* is the text here not just the usual white? 🥴 (Is it because the angle brackets are white? Why are the angle brackets white and not one of the usual accent colours?)
It's your choice, do whatever you think looks best. (Personally, I wonder what pink aside text + white main text would look like?)
Though I do want to ask if we really need a --secondary-text variable, or if using --primary-accent-lighter is sufficient?
@j285he The normal coloured text is definitely an improvement. I personally think the "About the Programs" header should be at least as dark as the "Computer Science"/"Computing and Financial Management"/"CS/BBA" headers - probably primary-accent for one and secondary-accent for the other? Or maybe x-accent for "About the Programs" and x-accent-light for the other. Here are some examples:
About the programs = primary-accent
Getting an overview... = primary-accent-lighter
CS/CFM/CSBBA = secondary-accent
Angle brackets = secondary-accent-light
About the programs = secondary-accent
Getting an overview... = primary-accent-lighter
CS/CFM/CSBBA = primary-accent
Angle brackets = primary-accent-light
@j285he The normal coloured text is definitely an improvement. I personally think the "About the Programs" header should be at least as dark as the "Computer Science"/"Computing and Financial Management"/"CS/BBA" headers - probably primary-accent for one and secondary-accent for the other? Or maybe x-accent for "About the Programs" and x-accent-light for the other. Here are some examples:
- About the programs = primary-accent
- Getting an overview... = primary-accent-lighter
- CS/CFM/CSBBA = secondary-accent
- Angle brackets = secondary-accent-light
-----
- About the programs = secondary-accent
- Getting an overview... = primary-accent-lighter
- CS/CFM/CSBBA = primary-accent
- Angle brackets = primary-accent-light
See my comment about maybe changing the colours up a bit more, but ultimately I'll leave it up to you - it's easy to change colours in the future if we want
See my comment about maybe changing the colours up a bit more, but ultimately I'll leave it up to you - it's easy to change colours in the future if we want
snedadah
e26chiu
b72zhou
a258wang
Closes #40.
Will look correct when !46 is merged in.
https://j285he-about-csc-class-profile-staging-snedadah.k8s.csclub.cloud/
.aboutWrapper {position: relative;flex-direction: column;Is
flex-direction: columnnecessary? Since the wrapper only has 1 non-absolutely-positioned child}.about {width: 90%;Is there any reason why we aren't doing
width: 100%(or maybe it's not even necessary to specify the width) and then just letting padding/margin handle the spacing?width: 90%;display: flex;flex-direction: row;background-color: var(--primary-background);Is the
background-colornecessary here? I would have thought that it'd just be transparent by default, which would be fine since the page background colour is what we want.}.about p {color: var(--secondary-text)I know this is a Figma thing and not an us thing, but why is the text here not just the usual white? 🥴 (Is it because the angle brackets are white? Why are the angle brackets white and not one of the usual accent colours?)
It's your choice, do whatever you think looks best. (Personally, I wonder what pink aside text + white main text would look like?)
Though I do want to ask if we really need a --secondary-text variable, or if using --primary-accent-lighter is sufficient?
I will remove --secondary-text (from light theme as well).
Also agree with the colours, how about this as a colour scheme?
@j285he The normal coloured text is definitely an improvement. I personally think the "About the Programs" header should be at least as dark as the "Computer Science"/"Computing and Financial Management"/"CS/BBA" headers - probably primary-accent for one and secondary-accent for the other? Or maybe x-accent for "About the Programs" and x-accent-light for the other. Here are some examples:
See my comment about maybe changing the colours up a bit more, but ultimately I'll leave it up to you - it's easy to change colours in the future if we want
.about aside {flex: 1;margin-right: 40px;NIT: rem
fc5600cb20into main 5 months agoReviewers
fc5600cb20.