www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add Histogram Component #66

Closed
e26chiu wants to merge 2 commits from histogram-component into main
pull from: histogram-component
merge into: www:main
Conversation 0 Commits 2 Files Changed 4 +55 -8
e26chiu commented 2022-09-28 18:42:33 -04:00
Contributor
Copy Link

This PR adds the histogram component. The histogram component is a bargraph component with few changes:

  • No space between bar (achieved by setting barPadding: 0 but this makes the bar wider)
  • Centered bars of graph in the grid (by extending the grid lines)

Note:

  • DEFAULT_LABEL_SIZE can be added as a global style to be reused in multiple components?

Screenshot:
image

Staging:
https://histogram-component-csc-class-profile-stagin-snedadah.k8s.csclub.cloud/

This PR adds the histogram component. The histogram component is a bargraph component with few changes: * No space between bar (achieved by setting `barPadding: 0` but this makes the bar wider) * Centered bars of graph in the grid (by extending the grid lines) Note: * `DEFAULT_LABEL_SIZE` can be added as a global style to be reused in multiple components? Screenshot: ![image](/attachments/cee1791f-affc-4a5c-b12c-1b4dde4affae) Staging: https://histogram-component-csc-class-profile-stagin-snedadah.k8s.csclub.cloud/
image.png
31 KiB
e26chiu added 2 commits 2022-09-28 18:42:34 -04:00
snedadah requested review from a258wang 2022-09-28 22:12:18 -04:00
a258wang reviewed 2022-10-02 15:07:27 -04:00
a258wang left a comment
Owner
Copy Link

This is great! My one nitpick is, can we figure out some way to have a 0 appear in the bottom left corner, on the x-axis? I'm thinking that we can change the format of the data prop that the Histogram takes in, and then transform the data before passing it into the Bar Graph (and perhaps change the shiftBottomAxis prop to be isHistogram and then we can use that to make sure everything works the way we want it to).
image

@e26chiu Let me know if you'd like to pair on this and we can find a time to tackle it together!

This is great! My one nitpick is, can we figure out some way to have a 0 appear in the bottom left corner, on the x-axis? I'm thinking that we can change the format of the data prop that the Histogram takes in, and then transform the data before passing it into the Bar Graph (and perhaps change the `shiftBottomAxis` prop to be `isHistogram` and then we can use that to make sure everything works the way we want it to). ![image](/attachments/f9b3092a-e7d9-425b-be70-375c26b87acf) @e26chiu Let me know if you'd like to pair on this and we can find a time to tackle it together!
image.png
22 KiB
snedadah closed this pull request 2023-02-04 01:49:29 -05:00
All checks were successful
continuous-integration/drone/push Build is passing
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
a258wang
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#66
No description provided.
Delete Branch "histogram-component"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?