www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add front page (Closes #44) #68

Merged
e26chiu merged 23 commits from j285he-front-page into main 2022-12-30 19:37:15 -05:00
Conversation 1 Commits 23 Files Changed 22 +342 -47
j285he commented 2022-10-02 16:00:05 -04:00
Member
Copy Link

Fixes #44.

https://j285he-front-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/

Fixes #44. https://j285he-front-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/
j285he added 6 commits 2022-10-02 16:00:06 -04:00
continuous-integration/drone/push Build is failing Details
8710faaa63 Initial HTML
continuous-integration/drone/push Build is failing Details
e8ce17fd82 Position fronpage items
continuous-integration/drone/push Build is failing Details
bc7de92f2d Fix Sections
continuous-integration/drone/push Build is failing Details
11c4c2d187 Align title elements
continuous-integration/drone/push Build is failing Details
5828e93c04 Remove px and add Title
j285he added 1 commit 2022-10-02 16:03:26 -04:00
continuous-integration/drone/push Build is passing Details
b4bf1bce85 Fix image
e26chiu reviewed 2022-10-09 17:52:45 -04:00
e26chiu left a comment
Contributor
Copy Link

Only 2 small comments. Otherwise it looks good to me! :D Good job @j285he !

image
Visual NIT: Is it possible to make the text "Lifestyle and Interests" have an indent after the line break so that we can keep a column of numbers? It would look cleaner. I'm not sure if this was included in the Figma design.

Also, I notice that we haven't yet made certain components reponsive. Is this something that we should do in this PR or in a separate issue/PR?

Only 2 small comments. Otherwise it looks good to me! :D Good job @j285he ! ![image](/attachments/81e6df8d-fb3b-404a-8502-ba971e95478f) Visual NIT: Is it possible to make the text "Lifestyle and Interests" have an indent after the line break so that we can keep a column of numbers? It would look cleaner. I'm not sure if this was included in the Figma design. Also, I notice that we haven't yet made certain components reponsive. Is this something that we should do in this PR or in a separate issue/PR?
image.png
48 KiB
components/Timeline.module.css Outdated
@ -15,6 +15,7 @@
display: flex;
flex-direction: column;
justify-content: space-around;
align-items: flex-end;
e26chiu commented 2022-10-09 17:00:22 -04:00
Contributor
Copy Link

I'm not really sure why you need a align-items: flex-end here? I removed it in the web development tools and it didn't change the position of the timeline component.

I'm not really sure why you need a `align-items: flex-end` here? I removed it in the web development tools and it didn't change the position of the timeline component.
j285he marked this conversation as resolved
pages/frontpage.module.css Outdated
@ -0,0 +36,4 @@
}
.blurb h1 {
margin-top: calc(0rem / 16);
e26chiu commented 2022-10-09 17:42:32 -04:00
Contributor
Copy Link
  margin-top: 0;

Not necessary, but this is the same thing.

```suggestion margin-top: 0; ``` Not necessary, but this is the same thing.
j285he marked this conversation as resolved
e26chiu requested review from e26chiu 2022-10-09 17:53:04 -04:00
j285he added 2 commits 2022-11-09 19:55:20 -05:00
continuous-integration/drone/push Build is passing Details
421fbac793 PR fixes
e26chiu changed title from Add front page to Add front page (Closes #44) 2022-12-19 21:59:22 -05:00
e26chiu added 2 commits 2022-12-19 23:05:12 -05:00
continuous-integration/drone/push Build is passing Details
b856471ea1 Make frontpage responsive
snedadah reviewed 2022-12-25 19:58:35 -05:00
snedadah left a comment
Owner
Copy Link

Looking great!

As we talked about before, we should work on removing the space at the top:
image

Also this text isn't centered:
image

Looking great! As we talked about before, we should work on removing the space at the top: ![image](/attachments/ff41b4f6-393e-47c0-a777-5cf65f2272e8) Also this text isn't centered: ![image](/attachments/2d994350-a526-473a-8563-1866efc2f19c)
image.png
155 KiB
image.png
116 KiB
e26chiu commented 2022-12-28 21:57:53 -05:00
Contributor
Copy Link

Make sure to fix the responsive issues.

ALSO, add a CALL TO ACTION BUTTON in FRONT PAGE to link to demographics page.

Make sure to fix the responsive issues. ALSO, add a CALL TO ACTION BUTTON in FRONT PAGE to link to demographics page.
snedadah added 4 commits 2022-12-29 04:10:03 -05:00
continuous-integration/drone/push Build is passing Details
4c0ede004b Adjusted front page
snedadah added 1 commit 2022-12-29 06:15:24 -05:00
continuous-integration/drone/push Build is passing Details
528cea2fd2 Added view button
e26chiu added 3 commits 2022-12-30 17:44:50 -05:00
continuous-integration/drone/push Build is passing Details
d486c9252f Adjust landing page text size
e26chiu approved these changes 2022-12-30 17:46:03 -05:00
e26chiu left a comment
Contributor
Copy Link

I'm good with the changes!

I'm good with the changes!
e26chiu added 1 commit 2022-12-30 17:55:07 -05:00
continuous-integration/drone/push Build is passing Details
a1cc7248e4 Add title
snedadah added 1 commit 2022-12-30 18:49:36 -05:00
continuous-integration/drone/push Build is passing Details
a104f21b01 Merge branch 'main' into j285he-front-page
snedadah added 1 commit 2022-12-30 19:00:05 -05:00
continuous-integration/drone/push Build is passing Details
7e51e4ee62 Fixed center wrapper
e26chiu added 1 commit 2022-12-30 19:18:28 -05:00
continuous-integration/drone/push Build is passing Details
97c49384f3 Add title to contributors
e26chiu merged commit 9a60c6b779 into main 2022-12-30 19:37:15 -05:00
e26chiu deleted branch j285he-front-page 2022-12-30 19:37:16 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#68
No description provided.
Delete Branch "j285he-front-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?