Add front page #68

Open
j285he wants to merge 9 commits from j285he-front-page into main
Collaborator
Fixes #44. https://j285he-front-page-csc-class-profile-staging-snedadah.k8s.csclub.cloud/
j285he added 6 commits 2 months ago
8710faaa63 Initial HTML
e8ce17fd82 Position fronpage items
bc7de92f2d Fix Sections
11c4c2d187 Align title elements
5828e93c04 Remove px and add Title
j285he added 1 commit 2 months ago
b4bf1bce85 Fix image
e26chiu reviewed 2 months ago
e26chiu left a comment
Collaborator

Only 2 small comments. Otherwise it looks good to me! :D Good job @j285he !

image
Visual NIT: Is it possible to make the text "Lifestyle and Interests" have an indent after the line break so that we can keep a column of numbers? It would look cleaner. I'm not sure if this was included in the Figma design.

Also, I notice that we haven't yet made certain components reponsive. Is this something that we should do in this PR or in a separate issue/PR?

Only 2 small comments. Otherwise it looks good to me! :D Good job @j285he ! ![image](/attachments/81e6df8d-fb3b-404a-8502-ba971e95478f) Visual NIT: Is it possible to make the text "Lifestyle and Interests" have an indent after the line break so that we can keep a column of numbers? It would look cleaner. I'm not sure if this was included in the Figma design. Also, I notice that we haven't yet made certain components reponsive. Is this something that we should do in this PR or in a separate issue/PR?
display: flex;
flex-direction: column;
justify-content: space-around;
align-items: flex-end;
Collaborator

I'm not really sure why you need a align-items: flex-end here? I removed it in the web development tools and it didn't change the position of the timeline component.

I'm not really sure why you need a `align-items: flex-end` here? I removed it in the web development tools and it didn't change the position of the timeline component.
j285he marked this conversation as resolved
}
.blurb h1 {
margin-top: calc(0rem / 16);
Collaborator
  margin-top: 0;

Not necessary, but this is the same thing.

```suggestion margin-top: 0; ``` Not necessary, but this is the same thing.
j285he marked this conversation as resolved
e26chiu requested review from e26chiu 2 months ago
j285he added 2 commits 4 weeks ago
421fbac793 PR fixes

Reviewers

e26chiu was requested for review 2 months ago
All checks were successful
continuous-integration/drone/push Build is passing
Required
Details
This Pull Request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#68
Loading…
There is no content yet.