www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add SectionHeader component (Closes #74) #75

Merged
e26chiu merged 4 commits from sectionheader-component into main 2022-11-05 09:01:47 -04:00
Conversation 0 Commits 4 Files Changed 3 +41
e26chiu commented 2022-11-03 22:32:12 -04:00
Contributor
Copy Link

This PR adds the SectionHeader component as described in the issue. The text is centered, so it's adapted for mobile. Possible improvements (or nitpicks) would be to add spacing around the text in mobile version (left and right margin/padding) or maybe make the title or subtitle smaller? I think it looks fine otherwise. Let me know what you think.

image

https://sectionheader-component-csc-class-profile-st-snedadah.k8s.csclub.cloud/

This PR adds the SectionHeader component as described in the issue. The text is centered, so it's adapted for mobile. Possible improvements (or nitpicks) would be to add spacing around the text in mobile version (left and right margin/padding) or maybe make the title or subtitle smaller? I think it looks fine otherwise. Let me know what you think. ![image](/attachments/9666a512-dd29-471a-943e-d91db7836bd9) https://sectionheader-component-csc-class-profile-st-snedadah.k8s.csclub.cloud/
image.png
43 KiB
e26chiu added 1 commit 2022-11-03 22:32:13 -04:00
continuous-integration/drone/push Build is failing Details
fde71730a0 Add SectionHeader component
e26chiu added 1 commit 2022-11-03 22:42:51 -04:00
continuous-integration/drone/push Build is passing Details
bd6459b592 Fix lint errors
snedadah approved these changes 2022-11-04 03:54:03 -04:00
snedadah left a comment
Owner
Copy Link

LGTM other than two small comments!

LGTM other than two small comments!
components/SectionHeader.module.css Outdated
@ -0,0 +18,4 @@
margin: auto;
}
.graphContainer {
snedadah commented 2022-11-04 03:50:41 -04:00
Owner
Copy Link

I think this style was left here on accident?

I think this style was left here on accident?
e26chiu commented 2022-11-04 09:07:04 -04:00
Author
Contributor
Copy Link

Yeah, I left it there by accident from my other PR. Thanks for noticing!

Yeah, I left it there by accident from my other PR. Thanks for noticing!
components/SectionHeader.tsx Outdated
@ -0,0 +4,4 @@
interface SectionHeaderProps {
title: string;
subtitle: string;
snedadah commented 2022-11-04 03:52:39 -04:00
Owner
Copy Link

We should probably make this optional, for example, for the contributors page it might not be needed?

We should probably make this optional, for example, for the contributors page it might not be needed?
e26chiu commented 2022-11-04 09:35:10 -04:00
Author
Contributor
Copy Link

Yup, I'll make the subtitle optional! Nice catch!

Yup, I'll make the subtitle optional! Nice catch!
e26chiu added 2 commits 2022-11-04 09:35:43 -04:00
continuous-integration/drone/push Build is passing Details
371848755f Remove unused code
e26chiu merged commit 7404c60d8f into main 2022-11-05 09:01:47 -04:00
e26chiu deleted branch sectionheader-component 2022-11-05 09:01:47 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#75
No description provided.
Delete Branch "sectionheader-component"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?