www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Created TooltipWrapper #88

Merged
snedadah merged 3 commits from shahanneda/merge-tooltip into main 2022-11-16 21:35:56 -05:00
Conversation 0 Commits 3 Files Changed 11 +316 -325
snedadah commented 2022-11-14 23:27:40 -05:00
Owner
Copy Link
No description provided.
snedadah added 1 commit 2022-11-14 23:27:41 -05:00
continuous-integration/drone/push Build is passing Details
387909f0c8 Created TooltipWrapper
snedadah reviewed 2022-11-14 23:29:48 -05:00
components/LineGraph.tsx
@ -119,4 +109,0 @@
}
});
const {
snedadah commented 2022-11-14 23:29:48 -05:00
Author
Owner
Copy Link

the only change I actually made to this file is removing the old tooltip, changing it to withTooltip, and using the tooltip wrapper. But that changed the indentation so it shows a lot of changes!

the only change I actually made to this file is removing the old tooltip, changing it to withTooltip, and using the tooltip wrapper. But that changed the indentation so it shows a lot of changes!
👍 1
snedadah reviewed 2022-11-14 23:30:12 -05:00
components/LineGraph.tsx
@ -312,0 +295,4 @@
}
/>
{tooltipOpen && (
snedadah commented 2022-11-14 23:30:12 -05:00
Author
Owner
Copy Link

key change I made. I'm not sure if we need the tooltip in portal. but seems to be working fine without it

key change I made. I'm not sure if we need the tooltip in portal. but seems to be working fine without it
👍 1
snedadah added 1 commit 2022-11-14 23:31:45 -05:00
continuous-integration/drone/push Build is passing Details
5e0f3be6fd Removed comment
snedadah force-pushed shahanneda/merge-tooltip from 5e0f3be6fd to eeecf60d02 2022-11-14 23:33:03 -05:00 Compare
e26chiu requested changes 2022-11-16 20:12:54 -05:00
e26chiu left a comment
Contributor
Copy Link

Tested the tooltip on all the mentioned components and it works! Most of it LGTM @snedadah ! Only small comment I'll make is to remove the LineGraph .tooltip class like you did for BoxPlot, WordCloud, and StackedBar.

Tested the tooltip on all the mentioned components and it works! Most of it LGTM @snedadah ! Only small comment I'll make is to remove the LineGraph `.tooltip` class like you did for BoxPlot, WordCloud, and StackedBar.
snedadah added 1 commit 2022-11-16 20:49:39 -05:00
continuous-integration/drone/push Build is passing Details
2701be38cb Removed unused style
e26chiu approved these changes 2022-11-16 20:50:45 -05:00
e26chiu left a comment
Contributor
Copy Link

LGTM! 🚀 Thanks for the quick update!

LGTM! 🚀 Thanks for the quick update!
snedadah merged commit 97aa2261f2 into main 2022-11-16 21:35:56 -05:00
snedadah deleted branch shahanneda/merge-tooltip 2022-11-16 21:35:56 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#88
No description provided.
Delete Branch "shahanneda/merge-tooltip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?