www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 22 Pull Requests 3 Projects Releases Wiki Activity
Labels Milestones

Created TooltipWrapper #88

Merged
snedadah merged 3 commits from shahanneda/merge-tooltip into main 3 months ago
Conversation 0 Commits 3 Files Changed 11
snedadah commented 3 months ago
Owner
There is no content yet.
snedadah added 1 commit 3 months ago
continuous-integration/drone/push Build is passing
Details
387909f0c8 Created TooltipWrapper
snedadah reviewed 3 months ago
components/LineGraph.tsx
}
});
const {
snedadah commented 3 months ago
Poster
Owner

the only change I actually made to this file is removing the old tooltip, changing it to withTooltip, and using the tooltip wrapper. But that changed the indentation so it shows a lot of changes!

the only change I actually made to this file is removing the old tooltip, changing it to withTooltip, and using the tooltip wrapper. But that changed the indentation so it shows a lot of changes!
👍 1
snedadah reviewed 3 months ago
components/LineGraph.tsx
}
/>
{tooltipOpen && (
snedadah commented 3 months ago
Poster
Owner

key change I made. I'm not sure if we need the tooltip in portal. but seems to be working fine without it

key change I made. I'm not sure if we need the tooltip in portal. but seems to be working fine without it
👍 1
snedadah added 1 commit 3 months ago
continuous-integration/drone/push Build is passing
Details
5e0f3be6fd Removed comment
snedadah force-pushed shahanneda/merge-tooltip from 5e0f3be6fd to eeecf60d02 3 months ago
e26chiu requested changes 3 months ago
e26chiu left a comment
Collaborator

Tested the tooltip on all the mentioned components and it works! Most of it LGTM @snedadah ! Only small comment I'll make is to remove the LineGraph .tooltip class like you did for BoxPlot, WordCloud, and StackedBar.

Tested the tooltip on all the mentioned components and it works! Most of it LGTM @snedadah ! Only small comment I'll make is to remove the LineGraph `.tooltip` class like you did for BoxPlot, WordCloud, and StackedBar.
snedadah added 1 commit 3 months ago
continuous-integration/drone/push Build is passing
Details
2701be38cb Removed unused style
e26chiu approved these changes 3 months ago
e26chiu left a comment
Collaborator

LGTM! 🚀 Thanks for the quick update!

LGTM! 🚀 Thanks for the quick update!
snedadah merged commit 97aa2261f2 into main 3 months ago
snedadah deleted branch shahanneda/merge-tooltip 3 months ago
snedadah referenced this issue from a commit 3 months ago
Created TooltipWrapper (#88)

Reviewers

e26chiu approved these changes 3 months ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 97aa2261f2.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
e26chiu
Labels
Apply labels
Clear labels
Bug Component Config Good First Issue Low-Priority Page
No Label Bug Component Config Good First Issue Low-Priority Page
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#88
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'shahanneda/merge-tooltip'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes