www
/
cs-2022-class-profile
16
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Enable customized colors for line graph #92

Merged
b72zhou merged 15 commits from line-graph-multiple-color into main 2022-11-30 21:48:37 -05:00
Conversation 3 Commits 15 Files Changed 4 +291 -236
b72zhou commented 2022-11-23 12:56:33 -05:00
Contributor
Copy Link
No description provided.
b72zhou added 11 commits 2022-11-23 12:56:34 -05:00
continuous-integration/drone/push Build is failing Details
dbe97f23b2 :feat: enable customized colors
b72zhou requested review from snedadah 2022-11-23 12:57:19 -05:00
e26chiu reviewed 2022-11-23 16:12:07 -05:00
components/LineGraph.tsx
@ -124,2 +126,4 @@
const xLength = data.xValues.length;
if (data.lines.length != colorRange.length) {
throw new Error("Invalid data with wrong length.");
e26chiu commented 2022-11-23 16:12:07 -05:00
Contributor
Copy Link

Nice catch here!

Nice catch here!
❤️ 1
b72zhou marked this conversation as resolved
e26chiu requested changes 2022-11-23 17:19:04 -05:00
e26chiu left a comment
Contributor
Copy Link

Hey @b72zhou ! Most of it LGTM! I think there are some linting errors to fix. Also, I'm running into this error Watchpack Error (watcher): Error: ENOSPC: System limit for number of file watchers reached, watch '/users/e26chiu/cs-2022-class-profile/node_modules/reduce-css-calc/node_modules' when I run npm run dev locally.
Does it happen to you too?

Hey @b72zhou ! Most of it LGTM! I think there are some linting errors to fix. Also, I'm running into this error `Watchpack Error (watcher): Error: ENOSPC: System limit for number of file watchers reached, watch '/users/e26chiu/cs-2022-class-profile/node_modules/reduce-css-calc/node_modules'` when I run `npm run dev` locally. Does it happen to you too?
components/LineGraph.tsx Outdated
@ -258,4 +264,2 @@
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
y={(d) => yScale(getY(d))!}
stroke={
isEven ? Color.primaryAccent : Color.secondaryAccent
e26chiu commented 2022-11-23 17:16:11 -05:00
Contributor
Copy Link

Since isEven is not used anymore, we can also remove the definition of that constant.

Since `isEven` is not used anymore, we can also remove the definition of that constant.
b72zhou marked this conversation as resolved
components/LineGraph.tsx Outdated
@ -60,6 +60,7 @@ interface LineGraphProps {
left: number;
right: number;
};
colorRange: string[];
e26chiu commented 2022-11-23 17:13:33 -05:00
Contributor
Copy Link

Perhaps add a comment here to mention that the length of colorRange should match the length of data and explains its purpose, i.e. List of hexademical colours for each line, length of the list should match the length of data.

Perhaps add a comment here to mention that the length of `colorRange` should match the length of `data` and explains its purpose, i.e. List of hexademical colours for each line, length of the list should match the length of data.
b72zhou marked this conversation as resolved
b72zhou added 1 commit 2022-11-30 10:03:53 -05:00
continuous-integration/drone/push Build is failing Details
a98089b289 :chore: review
b72zhou commented 2022-11-30 10:06:54 -05:00
Author
Contributor
Copy Link

Hey @b72zhou ! Most of it LGTM! I think there are some linting errors to fix. Also, I'm running into this error Watchpack Error (watcher): Error: ENOSPC: System limit for number of file watchers reached, watch '/users/e26chiu/cs-2022-class-profile/node_modules/reduce-css-calc/node_modules' when I run npm run dev locally.
Does it happen to you too?

Nope, it doesn't to me locally. It's weird, does it affect the rendering of pages?

@snedadah Could you please try to run dev locally and see if this happens to you?

> Hey @b72zhou ! Most of it LGTM! I think there are some linting errors to fix. Also, I'm running into this error `Watchpack Error (watcher): Error: ENOSPC: System limit for number of file watchers reached, watch '/users/e26chiu/cs-2022-class-profile/node_modules/reduce-css-calc/node_modules'` when I run `npm run dev` locally. > Does it happen to you too? Nope, it doesn't to me locally. It's weird, does it affect the rendering of pages? @snedadah Could you please try to run dev locally and see if this happens to you?
b72zhou commented 2022-11-30 10:14:05 -05:00
Author
Contributor
Copy Link

Hey @b72zhou ! Most of it LGTM! I think there are some linting errors to fix. Also, I'm running into this error Watchpack Error (watcher): Error: ENOSPC: System limit for number of file watchers reached, watch '/users/e26chiu/cs-2022-class-profile/node_modules/reduce-css-calc/node_modules' when I run npm run dev locally.
Does it happen to you too?

Nope, it doesn't to me locally. It's weird, does it affect the rendering of pages?

@snedadah Could you please try to run dev locally and see if this happens to you?

I found that it might be a prettier problem and I fix it now. Could you please try again and see if it's still there? @e26chiu

> > Hey @b72zhou ! Most of it LGTM! I think there are some linting errors to fix. Also, I'm running into this error `Watchpack Error (watcher): Error: ENOSPC: System limit for number of file watchers reached, watch '/users/e26chiu/cs-2022-class-profile/node_modules/reduce-css-calc/node_modules'` when I run `npm run dev` locally. > > Does it happen to you too? > > Nope, it doesn't to me locally. It's weird, does it affect the rendering of pages? > > @snedadah Could you please try to run dev locally and see if this happens to you? I found that it might be a prettier problem and I fix it now. Could you please try again and see if it's still there? @e26chiu
b72zhou added 1 commit 2022-11-30 10:14:50 -05:00
continuous-integration/drone/push Build is failing Details
0cc9e96cf0 :fix: lint
b72zhou added 1 commit 2022-11-30 10:35:22 -05:00
continuous-integration/drone/push Build is failing Details
19d53f969f :fix: build
b72zhou commented 2022-11-30 10:43:00 -05:00
Author
Contributor
Copy Link

@snedadah may need you to take a look...

latest: Pulling from plugins/docker
Digest: sha256:f0233d950ae87ee6cb5500b2d5497fe02aa338201c0bdce2619f443fd174cfa4
Status: Image is up to date for plugins/docker:latest
+ /usr/local/bin/dockerd --data-root /var/lib/docker --host=unix:///var/run/docker.sock
Detected registry credentials

Error response from daemon: Get "https://registry.cloud.csclub.uwaterloo.ca/v2/": unauthorized: authentication required

time="2022-11-30T15:38:13Z" level=fatal msg="Error authenticating: exit status 1"
@snedadah may need you to take a look... ``` latest: Pulling from plugins/docker Digest: sha256:f0233d950ae87ee6cb5500b2d5497fe02aa338201c0bdce2619f443fd174cfa4 Status: Image is up to date for plugins/docker:latest + /usr/local/bin/dockerd --data-root /var/lib/docker --host=unix:///var/run/docker.sock Detected registry credentials Error response from daemon: Get "https://registry.cloud.csclub.uwaterloo.ca/v2/": unauthorized: authentication required time="2022-11-30T15:38:13Z" level=fatal msg="Error authenticating: exit status 1" ```
😕 1
snedadah approved these changes 2022-11-30 14:01:12 -05:00
snedadah left a comment
Owner
Copy Link

LGTM! I don't have that issue when running anymore. @e26chiu could you confirm that you don't have that webpack issue?

LGTM! I don't have that issue when running anymore. @e26chiu could you confirm that you don't have that webpack issue?
b72zhou added 1 commit 2022-11-30 21:00:25 -05:00
continuous-integration/drone/push Build is passing Details
b3db878681 Merge branch 'main' into line-graph-multiple-color
b72zhou merged commit db9f74a42a into main 2022-11-30 21:48:37 -05:00
b72zhou deleted branch line-graph-multiple-color 2022-11-30 21:48:37 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
e26chiu
snedadah
Labels
Clear labels   
Bug

   
Component

   
Config

   
Good First Issue

   
Low-Priority

   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#92
No description provided.
Delete Branch "line-graph-multiple-color"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?