www
/
cs-2022-class-profile
17
0
Fork 0
Code Issues 11 Pull Requests 1 Projects Releases Wiki Activity

Add Postgrad Page (Close #58) #99

Merged
b72zhou merged 22 commits from b72zhou-postgrad-page into main 2022-12-07 21:24:03 -05:00
Conversation 0 Commits 22 Files Changed 2
b72zhou commented 2022-11-30 16:10:15 -05:00
repo.issues.collaborator

https://b72zhou-postgrad-page-csc-class-profile-stag-snedadah.k8s.csclub.cloud/postgrad/

https://b72zhou-postgrad-page-csc-class-profile-stag-snedadah.k8s.csclub.cloud/postgrad/
b72zhou added 12 commits 2022-11-30 16:10:17 -05:00
continuous-integration/drone/push Build is failing Details
4885499ad1 :feat: postgrad page
continuous-integration/drone/push Build is passing Details
9c958a6014 :fix: lint
b72zhou requested review from snedadah 2022-11-30 16:10:46 -05:00
b72zhou requested review from e26chiu 2022-11-30 16:10:46 -05:00
snedadah reviewed 2022-11-30 16:17:56 -05:00
snedadah left a comment
repo.issues.owner

Looking really good! As an initial comment, could you rename the files to "post-grad.tsx" (and post-grad.ts) to match the routes setout in data/routes.ts?

Looking really good! As an initial comment, could you rename the files to "post-grad.tsx" (and post-grad.ts) to match the routes setout in data/routes.ts?
👍 1
b72zhou added 1 commit 2022-11-30 22:05:27 -05:00
continuous-integration/drone/push Build is passing Details
7dfbe77e6e Merge branch 'main' into b72zhou-postgrad-page
b72zhou added 3 commits 2022-11-30 22:06:39 -05:00
e26chiu added 3 commits 2022-12-04 21:44:42 -05:00
continuous-integration/drone/push Build is passing Details
c03df2fdcb Merge WordCloud changes + fix lint
e26chiu approved these changes 2022-12-05 23:45:07 -05:00
e26chiu left a comment
repo.issues.collaborator

I made few changes, but otherwise LGTM! 😉

I made few changes, but otherwise LGTM! 😉
b72zhou added 1 commit 2022-12-07 21:11:04 -05:00
continuous-integration/drone/push Build is passing Details
87e7dd3b13 Merge branch 'main' into b72zhou-postgrad-page
b72zhou added 1 commit 2022-12-07 21:13:07 -05:00
continuous-integration/drone/push Build is passing Details
2267184586 Merge branch 'main' into b72zhou-postgrad-page
b72zhou added 1 commit 2022-12-07 21:14:54 -05:00
continuous-integration/drone/push Build is passing Details
c78cc0a4ff Merge branch 'main' into b72zhou-postgrad-page
b72zhou merged commit dbb1a5929f into main 2022-12-07 21:24:03 -05:00
b72zhou deleted branch b72zhou-postgrad-page 2022-12-07 21:24:03 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
e26chiu
Labels
Clear labels   
Bug
   
Component
   
Config
   
Good First Issue
   
Low-Priority
   
Page
No Label
Bug
Component
Config
Good First Issue
Low-Priority
Page
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/cs-2022-class-profile#99
No description provided.
Delete Branch "b72zhou-postgrad-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?