www
/
library
18
1
Fork 0
Code Issues 6 Pull Requests Projects Releases Wiki Activity

Add .drone.yml #12

Merged
j285he merged 4 commits from j285he-add-droneyml into main 2022-02-15 22:12:21 -05:00
Conversation 2 Commits 4 Files Changed 1 +24
j285he commented 2022-02-13 21:29:28 -05:00
Member
Copy Link

Not actually too sure what I'm doing and if this will work. Let me know.

Not actually too sure what I'm doing and if this will work. Let me know.
n3parikh was assigned by j285he 2022-02-13 21:29:28 -05:00
a258wang was assigned by j285he 2022-02-13 21:29:28 -05:00
j285he added 3 commits 2022-02-13 21:29:30 -05:00
a3thakra commented 2022-02-13 22:58:25 -05:00
Owner
Copy Link

The library is not a static app, correct? @n3parikh @a258wang

If so, then we can't npm run export the website, as the html content is dynamically generated.

@j285he if this this the case, then we should remove the export step, as well as the export command.

The library is not a static app, correct? @n3parikh @a258wang If so, then we can't `npm run export` the website, as the html content is dynamically generated. @j285he if this this the case, then we should remove the export step, as well as the export command.
👍 1
a3thakra reviewed 2022-02-13 23:02:22 -05:00
.drone.yml
@ -0,0 +9,4 @@
commands:
- npm install
- name: check-lockfile
a3thakra commented 2022-02-13 23:02:22 -05:00
Owner
Copy Link

You can also get rid of this.

Some context: When we were building the website npm v6 was fairly common which generated v1 lock files. npm 7 and 8 generate v2 lockfiles and these versions are common these days.

Nevertheless, if we want to run this as part of CI then that's fine too, but make sure to include the check-lockfiles.js file from the website as well.

You can also get rid of this. Some context: When we were building the website npm v6 was fairly common which generated v1 lock files. npm 7 and 8 generate v2 lockfiles and these versions are common these days. Nevertheless, if we want to run this as part of CI then that's fine too, but make sure to include the check-lockfiles.js file from the website as well.
a3thakra commented 2022-02-13 23:03:25 -05:00
Owner
Copy Link

looks good overall, feel free to schedule some time with either Neil or me if you wanna get some info as to what's going on.

looks good overall, feel free to schedule some time with either Neil or me if you wanna get some info as to what's going on.
j285he added 1 commit 2022-02-13 23:33:13 -05:00
a3thakra approved these changes 2022-02-14 02:46:11 -05:00
a258wang approved these changes 2022-02-15 17:22:16 -05:00
a258wang left a comment
Owner
Copy Link

Looks good to me! We can always tweak things in the future if needed.

Looks good to me! We can always tweak things in the future if needed.
n3parikh approved these changes 2022-02-15 21:12:09 -05:00
j285he merged commit 3765dc9daa into main 2022-02-15 22:12:21 -05:00
j285he referenced this issue from a commit 2022-02-15 22:12:22 -05:00
Add .drone.yml (#12)
j285he deleted branch j285he-add-droneyml 2022-03-16 19:58:57 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a3thakra
a258wang
n3parikh
Labels
Clear labels   
Backend

   
Frontend
No Label
Backend
Frontend
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
n3parikh
a258wang
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/library#12
No description provided.
Delete Branch "j285he-add-droneyml"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?