www
/
library
17
1
Fork 0
Code Issues 6 Pull Requests Projects Releases Wiki Activity
Labels Milestones

Add sqlite3 and modify prettier config #10

Merged
j285he merged 4 commits from j285he-add-sqlite3 into main 2 years ago
Conversation 3 Commits 4 Files Changed 10
j285he commented 2 years ago
Collaborator
There is no content yet.
j285he added 1 commit 2 years ago
j285he requested review from n3parikh 2 years ago
j285he requested review from a258wang 2 years ago
a258wang reviewed 2 years ago
.eslintrc.yml Outdated
- plugin:prettier/recommended
rules:
prettier/prettier: ['error', {semi: true}]
a258wang commented 2 years ago
Owner

Is the {semi: true} necessary here?

Is the `{semi: true}` necessary here?
j285he marked this conversation as resolved
a258wang reviewed 2 years ago
.prettierrc Outdated
"arrowParens": "avoid",
"singleQuote": true,
"semi": false,
"semi": true,
a258wang commented 2 years ago
Owner

It looks like the default Prettier options are more or less the same as what we want, so perhaps we could delete this file entirely? The website repo doesn't even have a .prettierrc, so getting rid of this file would make the Prettier rules more similar between the two repos. (If there's a reason why we maybe shouldn't try to align the Prettier config between both projects, please leave a comment!)

It looks like the default Prettier options are more or less the same as what we want, so perhaps we could delete this file entirely? The website repo doesn't even have a `.prettierrc`, so getting rid of this file would make the Prettier rules more similar between the two repos. (If there's a reason why we maybe shouldn't try to align the Prettier config between both projects, please leave a comment!)
j285he marked this conversation as resolved
a258wang commented 2 years ago
Owner

If we would like to try and align the formatting/config in this repo with the config in the website repo, then some additional things we could consider changing:

  • eslint.yml, line 24: we could remove the rules about quotes?
  • eslint.yml, line 35-37: we could change the import rules to be error instead of warn?
  • We could copy some of the config from .vscode in the website repo to this repo as well?
If we would like to try and align the formatting/config in this repo with the config in the website repo, then some additional things we could consider changing: - `eslint.yml`, line 24: we could remove the rules about quotes? - `eslint.yml`, line 35-37: we could change the import rules to be `error` instead of `warn`? - We could copy some of the config from `.vscode` in the website repo to this repo as well?
j285he added 1 commit 2 years ago
j285he added 1 commit 2 years ago
j285he commented 2 years ago
Poster
Collaborator

I copied eslintrc.js from www-new over to library and removed a few rules. Let me know and I can restore them if needed

on second thought it's probably easier to just copy over the entire file

I copied eslintrc.js from www-new over to library and removed a few rules. Let me know and I can restore them if needed on second thought it's probably easier to just copy over the entire file
👍 1
j285he added 1 commit 2 years ago
a258wang commented 2 years ago
Owner

Just throwing this here as a note, I realized that there are a few different node packages that we could potentially choose from for querying the SQLite database:

  • sqlite3: what we're currently planning on using, by far the most popular (487k weekly downloads on npm, 5.1k stars on Github)
  • better-sqlite3: claims to be faster than sqlite3, isn't quite as popular though (86k weekly downloads on npm, 2.7k stars on Github)
  • sqlite: basically sqlite3 but with promises instead of callbacks, not super popular (44k weekly downloads on npm, 706 stars on Github)

I'm personally happy to use sqlite3 as added in this PR, but I'll leave these findings here in case anyone wants to do a bit more research.

Just throwing this here as a note, I realized that there are a few different node packages that we could potentially choose from for querying the SQLite database: - [sqlite3](https://www.npmjs.com/package/sqlite3): what we're currently planning on using, by far the most popular (487k weekly downloads on npm, 5.1k stars on Github) - [better-sqlite3](https://www.npmjs.com/package/better-sqlite3): claims to be faster than sqlite3, isn't quite as popular though (86k weekly downloads on npm, 2.7k stars on Github) - [sqlite](https://www.npmjs.com/package/sqlite): basically sqlite3 but with promises instead of callbacks, not super popular (44k weekly downloads on npm, 706 stars on Github) I'm personally happy to use sqlite3 as added in this PR, but I'll leave these findings here in case anyone wants to do a bit more research.
a258wang approved these changes 2 years ago
a258wang left a comment
Owner

Looks good to me! We can continue to tweak things in the future as we see fit. Thank you Jared for getting this all set up! 🙂

Looks good to me! We can continue to tweak things in the future as we see fit. Thank you Jared for getting this all set up! 🙂
j285he merged commit 3ed6d703a9 into main 2 years ago
j285he deleted branch j285he-add-sqlite3 2 years ago

Reviewers

n3parikh was requested for review 2 years ago
a258wang approved these changes 2 years ago
The pull request has been merged as 3ed6d703a9.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
n3parikh
a258wang
Labels
Apply labels
Clear labels
Backend Frontend
No Label Backend Frontend
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/library#10
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'j285he-add-sqlite3'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes