a3thakra
a258wang
n3parikh
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'j285he-add-droneyml'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Deleting a branch is permanent. It CANNOT be undone. Continue?
Not actually too sure what I'm doing and if this will work. Let me know.
The library is not a static app, correct? @n3parikh @a258wang
If so, then we can't
npm run exportthe website, as the html content is dynamically generated.@j285he if this this the case, then we should remove the export step, as well as the export command.
commands:- npm install- name: check-lockfileYou can also get rid of this.
Some context: When we were building the website npm v6 was fairly common which generated v1 lock files. npm 7 and 8 generate v2 lockfiles and these versions are common these days.
Nevertheless, if we want to run this as part of CI then that's fine too, but make sure to include the check-lockfiles.js file from the website as well.
looks good overall, feel free to schedule some time with either Neil or me if you wanna get some info as to what's going on.
Looks good to me! We can always tweak things in the future if needed.
3765dc9daainto main 1 year agoReviewers
3765dc9daa.