Add .drone.yml #12

Merged
j285he merged 4 commits from j285he-add-droneyml into main 6 months ago
j285he commented 6 months ago
Collaborator

Not actually too sure what I'm doing and if this will work. Let me know.

Not actually too sure what I'm doing and if this will work. Let me know.
n3parikh was assigned by j285he 6 months ago
a258wang was assigned by j285he 6 months ago
j285he added 3 commits 6 months ago
Owner

The library is not a static app, correct? @n3parikh @a258wang

If so, then we can't npm run export the website, as the html content is dynamically generated.

@j285he if this this the case, then we should remove the export step, as well as the export command.

The library is not a static app, correct? @n3parikh @a258wang If so, then we can't `npm run export` the website, as the html content is dynamically generated. @j285he if this this the case, then we should remove the export step, as well as the export command.
a3thakra reviewed 6 months ago
commands:
- npm install
- name: check-lockfile
Owner

You can also get rid of this.

Some context: When we were building the website npm v6 was fairly common which generated v1 lock files. npm 7 and 8 generate v2 lockfiles and these versions are common these days.

Nevertheless, if we want to run this as part of CI then that's fine too, but make sure to include the check-lockfiles.js file from the website as well.

You can also get rid of this. Some context: When we were building the website npm v6 was fairly common which generated v1 lock files. npm 7 and 8 generate v2 lockfiles and these versions are common these days. Nevertheless, if we want to run this as part of CI then that's fine too, but make sure to include the check-lockfiles.js file from the website as well.
Owner

looks good overall, feel free to schedule some time with either Neil or me if you wanna get some info as to what's going on.

looks good overall, feel free to schedule some time with either Neil or me if you wanna get some info as to what's going on.
j285he added 1 commit 6 months ago
a3thakra approved these changes 6 months ago
a258wang approved these changes 6 months ago
a258wang left a comment
Owner

Looks good to me! We can always tweak things in the future if needed.

Looks good to me! We can always tweak things in the future if needed.
n3parikh approved these changes 6 months ago
j285he merged commit 3765dc9daa into main 6 months ago
j285he referenced this issue from a commit 6 months ago
j285he deleted branch j285he-add-droneyml 5 months ago

Reviewers

a3thakra approved these changes 6 months ago
a258wang approved these changes 6 months ago
n3parikh approved these changes 6 months ago
The pull request has been merged as 3765dc9daa.
Sign in to join this conversation.
No Milestone
No project
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.