continuous-integration/drone/push Build is passingDetails
Previously, the instructions for "Online Term" on the Get Involved page would be open by default. This PR changes the instructions for "In Person" to be open by default.
There are also some other small wording changes on the Get Involved page.
Co-authored-by: Amy <a258wang@uwaterloo.ca>
Reviewed-on: #429
Reviewed-by: b38peng <b38peng@uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Please confirm the time -- should it be 2-3pm EST or EDT?
Co-authored-by: Jared He <66887902+jaredjhe@users.noreply.github.com>
Reviewed-on: #416
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Updated the website with some past and upcoming events.
All three Tesla coffee chat events are currently using the Autopilot Coffee Chat graphic, since different graphics do not exist for the Vehicle Software Systems and Vehicle Software Development coffee chats yet.
Co-authored-by: Amy <a258wang@uwaterloo.ca>
Reviewed-on: #408
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Update:
In order to solve the issues discussed below, we decided to put the warnings in a json file, since they can be easily imported into a javascript file and webpack automatically bundles them with the client side app, so no static props is needed.
__________
To get the warning data, since it is something that needs to be on all pages, it makes sense for the component to go in the app.js file (similar to the nav bar). However, next.js has a cumbersome issue that it does not support getStaticProps in the app.ts file (and getStaticProps only works in page files), thus we have no way of requesting the warning data easily in the \<WarningHeader\> Component. (https://github.com/vercel/next.js/discussions/10949)
Here is my solution:
- Request the warning data on the client side through the use of an api.
- I made a warning api (/api/currentWarning) which sends a json of the current warning
- Advantage: warnings will always be up to date since it is recalculated on every request
- Advantage: It can potentially incorporate with other CSC services who might need to know about the warning (eg linktree?)
- Disadvantage: can get expensive if we have a lot of warnings, to fix this I can cache the current warning and only re-read the files every 24h if this is a problem, but if we don’t have that many warnings I think it should be fine
- Disadvantage: listed below:
The current problem with what I implemented is that it doesn’t build in the production environment:
- The way we build the website, when we call “next export” that disables any api endpoints.
- According to this https://github.com/vercel/vercel/discussions/6551, if we want to allow api endpoints, we have to just do “next build”. This has implications that the site won’t be completely static anymore, but the other solutions also have similar problems ( though the GitHub post says that next will still optimize for static with only next build).
Another advantage of allowing api’s is that maybe in the future we will implement other features where an api might be useful.
If you want to try it out, my branch works fine locally (when just running npm run dev or npm run build”)
Other possible solutions:
- Use getInitialProps inside _app.js, but this has the downside that it will “disable Automatic Static Optimization in pages without Static Generation.” (https://nextjs.org/docs/advanced-features/custom-app), which I believe will slow the whole site down, but, we will be able to still use the old build command I think, I am not sure of the full effect of this.
- However, implementing this would also be relatively simple.
- Add the warning request to the getStaticProps of every single page, possibly through some wrapper component around every single page, this has the disadvantage that we need to do a lot of refactoring of all the pages of the site and cant use the intended “_app.ts” wrapper.
- Add warning header only to the homepage (or maybe one or two other important pages).
Co-authored-by: shahanneda <shahan.neda@gmail.com>
Reviewed-on: #394
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
If Head of Discord, Heads of Design, Head of Reps are to be included, just notify me ~ 😃
Co-authored-by: Rebecca-Chou <beihaozhou@gmail.com>
Reviewed-on: #383
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
Reviewed-by: j285he <j285he@localhost>
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
Co-authored-by: Beihao Zhou <b72zhou@csclub.uwaterloo.ca>
Co-committed-by: Beihao Zhou <b72zhou@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Reviewed-on: #395
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-authored-by: Raymond Li <raymo@csclub.uwaterloo.ca>
Co-committed-by: Raymond Li <raymo@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Andy (Head of Discord) asked that we change the label for the Discord team members on the Meet the Team page from "Discord Mod" to either "Codey Coder" or "Discord". I have opted to change it to simply "Discord" for clarity.
When we separate the teams on the Meet the Team page (#364), please change "Discord" to "Developer" (similar to what we have for the Web Committee).
Co-authored-by: Amy <a258wang@uwaterloo.ca>
Reviewed-on: #393
Reviewed-by: Emily Chiu <e26chiu@csclub.uwaterloo.ca>
Co-authored-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-committed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Added the upcoming Afterhours: Diversity in Tech event, as well as the Beginning of Term event that happened last week.
Co-authored-by: Amy <a258wang@uwaterloo.ca>
Reviewed-on: #389
Reviewed-by: Emily Chiu <e26chiu@csclub.uwaterloo.ca>
Co-authored-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-committed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Updating my own bio for a couple days until it gets changed again. :)
Reviewed-on: #353
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
Co-authored-by: k4tu <k4tu@localhost>
Co-committed-by: k4tu <k4tu@localhost>
continuous-integration/drone/push Build is passingDetails
Reviewed-on: #347
Reviewed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-authored-by: Raymond Li <raymo@csclub.uwaterloo.ca>
Co-committed-by: Raymond Li <raymo@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
New syscom member 😎
Reviewed-on: #335
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
Co-authored-by: Max Erenberg <merenber@csclub.uwaterloo.ca>
Co-committed-by: Max Erenberg <merenber@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Closes#134
- Dynamically generates the calendar before the export step
- I tested it with google calendar, updates are propagating as expected (it takes a day for google calendar to get updated)
You can try adding this URL to your calendar to test things out: https://csclub.uwaterloo.ca/~a3thakra/csc/adi-ical/events.ics
Reviewed-on: #332
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
While converting tech talks, I wrongly placed the quotes in the
presentors array. This fixes that.
Reviewed-on: #270
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Place the PayPal link under the Online section.
Remove the part about MathSoc waiving fees (since we don't know if that will happen yet).
Co-authored-by: Max Erenberg <merenber@csclub.uwaterloo.ca>
Reviewed-on: #290
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
Reviewed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-authored-by: Max Erenberg <merenber@csclub.uwaterloo.ca>
Co-committed-by: Max Erenberg <merenber@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Make sure that the advice, team, and tech-talk pages are loading properly
Reviewed-on: #289
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
The script missed some news items, where the author and the date was the
same. I appended all news with a uuid to make sure that we are not
over-writing an already existing news.
Reviewed-on: #275
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Implements all the changes mentioned in #237, except for the following:
- Services, Live Streaming - "Icecast" still links to https://icy.csclub.uwaterloo.ca/
- Services, In-Office Books - "extensive collection of Computer Science-related books" still links to http://csclub.uwaterloo.ca/library/
(If these items need to be changed, then we can create new issues for them)
Closes#237
Co-authored-by: Amy <a258wang@uwaterloo.ca>
Reviewed-on: #246
Reviewed-by: j285he <j285he@localhost>
Reviewed-by: n3parikh <n3parikh@localhost>
Co-authored-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-committed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Closes#221
Go to https://csclub.uwaterloo.ca/~a3thakra/csc/adi-page-titles and make sure that all pages have a title (you can hover over the tab)
Reviewed-on: #222
Reviewed-by: j285he <j285he@localhost>
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
If we don't, then `new Date(dateString)` actually interprets it as time in UTC, which is 4/5 hours ahead of EDT/EST. This means that the actual date in the news card is 1 day before the actual date.
https://csclub.uwaterloo.ca/~a3thakra/csc/adi-news-dates
Reviewed-on: #177
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
closes#13 and #24
- added the `<EmailSignup>` and `<ConnectWithUs>` components!
- adds the Get Involved Page
Co-authored-by: dora <d43su@uwaterloo.ca>
Co-authored-by: dora <d43su@csclub.uwaterloo.ca>
Reviewed-on: #76
Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Amy Wang
Beihao Zhou
Shahan Nedadahandeh
Jared He
Raymond Li
Mark Chiu
Max Erenberg
k4tu
Neil Parikh
Aditya Thakral
c29wan
William Tran
l42luo
b38peng
Bonnie Peng
Neil Parikh
William Tran
Amy Wang
Aditya Thakral
Jared He
Dora Su
Linhui Luo