www-new

Commit Graph

Author	SHA1	Message	Date
Amy Wang	14ef810ad9	Image Optimization - Create new ImagePool for each batch (#470 ) continuous-integration/drone/push Build is passing Details We have been having issues with the image optimization script consuming egregious amounts of memory and failing CI as a result. This PR changes the script so that we use a new `ImagePool` to process each batch of images. Co-authored-by: Amy <a258wang@uwaterloo.ca> Reviewed-on: #470 Reviewed-by: Shahan Neda <snedadah@csclub.uwaterloo.ca>	11 months ago
Amy Wang	443925190e	Improve image optimization run-time and memory usage (#457 ) continuous-integration/drone/push Build is passing Details This PR aims to resolve the issues surrounding the optimize-images script, at least in the short term, in order to unblock other work. Problems: Our optimize-images script was taking a very long time to run (~7 minutes in CI, when successful). This led to two problems: 1. It was near impossible to run the script locally. 2. CI jobs would often get killed on the optimize-images step. Solutions: 1. Resize the images in `images/events` prior to optimizing them, similar to what is done for the images in `images/team`. This solution on its own reduced the run-time of the script to ~30 seconds locally on Amy's laptop, which is comparable to the run-time of the script back when it was originally written. 2. EDIT: Copy/resize/optimize the images in batches of 32 at a time. The reason why the CI job was being killed is because the script would run out of memory, however this change should resolve that while also keeping build times reasonable (~30 sec locally/when deploying on caffeine, ~3 min in CI). ~~As a temporary fix, this PR also replaces the images in `images/events` with their resized + optimized versions. (For some unknown reason, Solution 1 is not sufficient to solve Problem 2.)~~ This PR also adds some logging to the script so we can get a (slightly) better sense of where the script is getting stuck. Related issue: #456 Co-authored-by: Amy <a258wang@uwaterloo.ca> Reviewed-on: #457 Reviewed-by: Shahan Neda <snedadah@csclub.uwaterloo.ca>	1 year ago
Shahan Nedadahandeh	f12ffbb925	Add endDate to events (#446 ) continuous-integration/drone/push Build is passing Details Added endDate to events.	1 year ago
Shahan Nedadahandeh	bb78a3d53d	Warning Header (Closes #205 ) (#394 ) continuous-integration/drone/push Build is passing Details Update: In order to solve the issues discussed below, we decided to put the warnings in a json file, since they can be easily imported into a javascript file and webpack automatically bundles them with the client side app, so no static props is needed. __________ To get the warning data, since it is something that needs to be on all pages, it makes sense for the component to go in the app.js file (similar to the nav bar). However, next.js has a cumbersome issue that it does not support getStaticProps in the app.ts file (and getStaticProps only works in page files), thus we have no way of requesting the warning data easily in the \<WarningHeader\> Component. (https://github.com/vercel/next.js/discussions/10949) Here is my solution: - Request the warning data on the client side through the use of an api. - I made a warning api (/api/currentWarning) which sends a json of the current warning - Advantage: warnings will always be up to date since it is recalculated on every request - Advantage: It can potentially incorporate with other CSC services who might need to know about the warning (eg linktree?) - Disadvantage: can get expensive if we have a lot of warnings, to fix this I can cache the current warning and only re-read the files every 24h if this is a problem, but if we don’t have that many warnings I think it should be fine - Disadvantage: listed below: The current problem with what I implemented is that it doesn’t build in the production environment: - The way we build the website, when we call “next export” that disables any api endpoints. - According to this https://github.com/vercel/vercel/discussions/6551, if we want to allow api endpoints, we have to just do “next build”. This has implications that the site won’t be completely static anymore, but the other solutions also have similar problems ( though the GitHub post says that next will still optimize for static with only next build). Another advantage of allowing api’s is that maybe in the future we will implement other features where an api might be useful. If you want to try it out, my branch works fine locally (when just running npm run dev or npm run build”) Other possible solutions: - Use getInitialProps inside _app.js, but this has the downside that it will “disable Automatic Static Optimization in pages without Static Generation.” (https://nextjs.org/docs/advanced-features/custom-app), which I believe will slow the whole site down, but, we will be able to still use the old build command I think, I am not sure of the full effect of this. - However, implementing this would also be relatively simple. - Add the warning request to the getStaticProps of every single page, possibly through some wrapper component around every single page, this has the disadvantage that we need to do a lot of refactoring of all the pages of the site and cant use the intended “_app.ts” wrapper. - Add warning header only to the homepage (or maybe one or two other important pages). Co-authored-by: shahanneda <shahan.neda@gmail.com> Reviewed-on: #394 Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>	1 year ago
Amy Wang	aae5c9adef	Image Optimization Script (#348 ) continuous-integration/drone/push Build is passing Details A build-time script to optimize images. Note that going forward, all images should be placed in `images` instead of `public/images`. Co-authored-by: Amy <a258wang@uwaterloo.ca> Reviewed-on: #348 Reviewed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca> Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca> Co-authored-by: Amy <a258wang@csclub.uwaterloo.ca> Co-committed-by: Amy <a258wang@csclub.uwaterloo.ca>	2 years ago
Aditya Thakral	47352f4e82	Change date format for events and news (#343 ) continuous-integration/drone/push Build is passing Details https://csclub.uwaterloo.ca/~a3thakra/csc/adi-event-dates Reviewed-on: #343 Reviewed-by: b38peng <b38peng@uwaterloo.ca> Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca> Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>	2 years ago
Aditya Thakral	34fb652fb9	Dynamically generate event calendar (#332 ) continuous-integration/drone/push Build is passing Details Closes #134 - Dynamically generates the calendar before the export step - I tested it with google calendar, updates are propagating as expected (it takes a day for google calendar to get updated) You can try adding this URL to your calendar to test things out: https://csclub.uwaterloo.ca/~a3thakra/csc/adi-ical/events.ics Reviewed-on: #332 Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca> Co-authored-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca> Co-committed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>	2 years ago

7 Commits (amy-update-community-reps)